chore: remove unused SelectEphemeral and SelectByPurpose label selectors - #1918
Open
detail-app[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused SelectEphemeral() and SelectByPurpose() helper functions
from framework/kubernetes/kubedef/labels.go. Both functions had zero
callers anywhere in the codebase (no production, no tests). Their only
historical consumer was orchestration/legacycontroller/ephemeral.go, which
was deleted in #1612 ("orchestration/server: remove controllers, unused.") -
for SelectByPurpose even that usage was already commented out.
The constants they referenced (K8sEnvEphemeral, K8sEnvPurpose) remain
living via MakeLabels, so no further cascading removals were needed.
History
Dead Code PRs can be configured here.