Added new storage key that allows looking up a wasm name from a hash - #4690
Open
batconjurer wants to merge 3 commits into
Open
Added new storage key that allows looking up a wasm name from a hash#4690batconjurer wants to merge 3 commits into
batconjurer wants to merge 3 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4690 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sug0
requested changes
Jun 9, 2025
Contributor
|
We should close and abandon this now though, right? @batconjurer |
Collaborator
|
no, we still need this pr, to look-up the tx code aliases |
sug0
approved these changes
Jun 9, 2025
tzemanovic
added
the
requires-migration
tzemanovic
added a commit
that referenced
this pull request
Jul 16, 2025
* origin/bat/wasm-name-lookups: Fix changelog Added changelog Added new storage key that allows looking up a wasm name from a hash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indexers fail to identify the types of older txs since these types use wasm hasheh. If those hashes were overwritten by governance proposals, the indexer is unable to determine how to deserialize these txs. This PR adds a new key to storage which allows looking up a tx type from a wasm hash, even if that hash is of code no longer in use.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo