Skip to content

fix: add /usr/local/bin symlink for nacos-setup to persist across shell sessions #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiacheng7 merged 1 commit into from
May 20, 2026
Merged

fix: add /usr/local/bin symlink for nacos-setup to persist across shell sessions #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions nacos-installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,25 @@ install_nacos_setup() {

# Export version for later use
INSTALLED_VERSION="$setup_version"

_nacos_try_link_nacos_setup_system_symlink "$BIN_DIR/$SCRIPT_NAME"
}

# If /usr/local/bin is writable, symlink nacos-setup there so it is available
# immediately even when the installer was invoked via sudo (which changes $HOME).
_nacos_try_link_nacos_setup_system_symlink() {
local src="$1"
local dst="/usr/local/bin/nacos-setup"
[ -n "$src" ] && [ -f "$src" ] || return 0
if [ ! -d /usr/local/bin ]; then
mkdir -p /usr/local/bin 2>/dev/null || return 0
fi
if [ ! -w /usr/local/bin ]; then
return 0
fi
if ln -sf "$src" "$dst" 2>/dev/null; then
print_success "Linked nacos-setup to $dst (available without source ~/.bashrc)"
fi
}

# ============================================================================
Expand Down Expand Up @@ -825,6 +844,16 @@ uninstall_nacos_setup() {
print_success "Removed $BIN_DIR/$SCRIPT_NAME"
fi

# Remove installer symlink in /usr/local/bin if it points to our nacos-setup
if [ -L /usr/local/bin/nacos-setup ]; then
local link_tgt
link_tgt=$(readlink /usr/local/bin/nacos-setup 2>/dev/null || true)
if [[ "$link_tgt" == "$BIN_DIR/$SCRIPT_NAME" ]]; then
rm -f /usr/local/bin/nacos-setup
print_success "Removed /usr/local/bin/nacos-setup"
fi
fi

# Remove installer symlink in /usr/local/bin if it points to our nacos-cli
if [ -L /usr/local/bin/nacos-cli ]; then
local link_tgt
Expand Down
Loading