Skip to content

Update ssl_profiles.js#2569

Open
whatadewitt wants to merge 1 commit intomysqljs:masterfrom
whatadewitt:master
Open

Update ssl_profiles.js#2569
whatadewitt wants to merge 1 commit intomysqljs:masterfrom
whatadewitt:master

Conversation

@whatadewitt
Copy link
Copy Markdown

update Amazon RDS profiles to latest

context: working on a project with legacy codebase. need to update to a newer cert by aug 22, 2024. i can use a fork to handle this, but figure it might save some people some of the headaches i've been dealing with.

update Amazon RDS profiles to latest
@whatadewitt
Copy link
Copy Markdown
Author

If this seems ok, let me know and I can submit with an updated version as well.

@sidorares
Copy link
Copy Markdown
Member

@whatadewitt maybe worth switching to https://github.com/mysqljs/aws-ssl-profiles - see some context in sidorares/node-mysql2#2581

@dougwilson
Copy link
Copy Markdown
Member

Ya, there isn't a huge reason to update the built in certs here, as the new module splits them out. The separate module is great too bc then updating certs is separate from the version of the mysql module version as wlel.

https://github.com/mysqljs/aws-ssl-profiles?tab=readme-ov-file#mysqljsmysql is the usage example for how to uae the newest certs with thia module if it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants