Add stackCycle feature for decrease useless connections#1805
Open
davidshimjs wants to merge 2 commits intomysqljs:masterfrom
Open
Add stackCycle feature for decrease useless connections#1805davidshimjs wants to merge 2 commits intomysqljs:masterfrom
davidshimjs wants to merge 2 commits intomysqljs:masterfrom
Conversation
|
config.mysqlConfig.options = { |
Author
|
@Robert-lihouyi What's your point? If you just want to listen answer, you can check out more information https://github.com/mysqljs/mysql#pooling-connections |
|
issue resolved, thanks very much
姓名:李厚毅
联系电话:18101082232
职位:高级前端工程师
…________________________________
From: Sangmin, Shim <notifications@github.com>
Sent: Thursday, August 24, 2017 8:13:51 PM
To: mysqljs/mysql
Cc: Robert; Mention
Subject: Re: [mysqljs/mysql] Add stackCycle feature for decrease useless connections (#1805)
@Robert-lihouyi<https://github.com/robert-lihouyi> What's your point? If you just want to listen answer, you can check out more information https://github.com/mysqljs/mysql#pooling-connections
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1805 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOqYFktaxy6BLZOnI1nMh8CdPvje_nc8ks5sbWj_gaJpZM4O7yo6>.
|
946727b to
37fbbdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are using a connection pool and suddenly handle more traffic than usual, the size of the connection pool increases. And the increased connections will survive because of the wait_timeout setting. (It usually set as 10-30 seconds) Keeping unnecessary connections is not good for running multiple servers.
However, this problem can not be solved because the mysql module only supports round-robin styles. So I added a pool option called stackCycle.