Register of interest page layout#2022
Conversation
|
So mostly looks good!
|
Just to clarify the styling is the same, however the content/copy is different. I'm happy to go with this approach if we can have different content in the MP and Register of Interest.
Perfect I'll rebase this one with master once we have merge this PR and make the changes. |
81d1041 to
a9eaab8
Compare
- Moved styles from the `_mp.scss` page to `_in-page-nav.scss` - Fix wrong hierarchy markup in where the main title of the navigation was an `h3` element and then children were `h2`.
It creates a side menu from markdown template that uses the same classes as `.js-table-of-content` allowing the same style navigation we use in the MP pages.
90e4317 to
f4b0914
Compare
f4b0914 to
0407f72
Compare
- Deleted the first line on each template so they can be reused and the variable `$featured_item` and `newsletter_item` can have different copies. - Updated `mp/_sidebar.php` so it uses the correct variable `$featured_item`
|
@ajparsons I just added two commits that follows the same logic for the announcements in the MP page. I also included some commits to:
|
|
@ajparsons I think this should be ready for review: |
Fixes: #2015
The following changes have been made:
in-page-navto its own stylesheet. So we can reuse it in other pages..js-table-of-content-markdownthat creates from the markdown a table of content with the proper classes so it can use the current functionality/styles ofjs-table-of-content