Skip to content

[Aurora] Handle 5K limit when getting filenames from Azure Storage Container.#515

Merged
neprune merged 3 commits into
masterfrom
aurora-paginate
May 27, 2026
Merged

[Aurora] Handle 5K limit when getting filenames from Azure Storage Container.#515
neprune merged 3 commits into
masterfrom
aurora-paginate

Conversation

@neprune

@neprune neprune commented May 27, 2026

Copy link
Copy Markdown
Contributor

For https://mysocietysupport.freshdesk.com/a/tickets/7012.

Verfiied locally that the missing updates come through with this.

@neprune neprune force-pushed the aurora-paginate branch from f0fa655 to 9b3da48 Compare May 27, 2026 16:03
@neprune neprune force-pushed the aurora-paginate branch 2 times, most recently from 5e15097 to 0bc69d5 Compare May 27, 2026 16:08
@neprune neprune requested a review from dracos May 27, 2026 16:09

@dracos dracos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're sure the filenames are in UTC :)
Could also bail out if marker == next_marker I guess, to prevent a loop there, but assume that shouldn't ever happen.

@neprune

neprune commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

As long as we're sure the filenames are in UTC :) Could also bail out if marker == next_marker I guess, to prevent a loop there, but assume that shouldn't ever happen.

Whoops, yep, out they are currently on BST going by the timestamp recorded in the file vs the filename. This meant we also had an existing bug in _skip_update_file where we were an hour late to reading update . Although thankfully we are at least still populating the update time from the UTC timestamp in the update file ok.

Have updated to use Europe/London.

@neprune neprune force-pushed the aurora-paginate branch from 1ec957e to 31e85f7 Compare May 27, 2026 17:05
@neprune neprune merged commit 31e85f7 into master May 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants