[Dumfries] Add Inspector notes to report with update#513
Open
MorayMySoc wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I'm unsure how to check this against a real world defect, to see what the attributes are and if they are strings. |
Adapts current adding of specific alloy attributes to
extra->{detailed_information} to allow multiple attributes
to be added as suggests there are in request.
Test for non array attribute config is in northumberland.t
mysociety/societyworks#5477
mysociety-pusher
force-pushed
the
5477-add-inspectors-notes
branch
from
654d312 to
c9ab42d
Compare
davea
approved these changes
May 14, 2026
davea
left a comment
davea
left a comment
Member
There was a problem hiding this comment.
Code looks good to me. Have left more thoughts and some attribute names on the original ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts current adding of specific alloy attributes to extra->{detailed_information} to allow multiple attributes to be added as suggests there are in request.
Test for non array attribute config is in northumberland.t
Code for picking up detailed_information already in perllib/Open311/UpdatesBase.pm
https://github.com/mysociety/societyworks/issues/5477