[Dumfries] Setting 'responsibility' on the extras of an update#512
Open
MorayMySoc wants to merge 1 commit into
Open
[Dumfries] Setting 'responsibility' on the extras of an update#512MorayMySoc wants to merge 1 commit into
MorayMySoc wants to merge 1 commit into
Conversation
davea
requested changes
May 14, 2026
davea
left a comment
davea
left a comment
Member
There was a problem hiding this comment.
A couple of small things in the code. However I've also not actually been able to get this to return any values even when running against the live API. So not quite sure what's going on.
| } | ||
|
|
||
| my $mapping = $self->config->{other_responsibility_mapping}; | ||
| if ( |
Member
There was a problem hiding this comment.
If other_responsibility_mapping isn't set in config this prints a bunch of warnings, maybe we should check for $mapping too?
| my $mapping = $self->config->{other_responsibility_mapping}; | ||
| if ( | ||
| my $responsibility = $inspection_attrs->{ $mapping->{'highway'} } | ||
| || $inspection_attrs->{$mapping}{'streetlight'} |
Member
There was a problem hiding this comment.
This is inconsistent with the structure on the previous line, I think it should be this:
Suggested change
| || $inspection_attrs->{$mapping}{'streetlight'} | |
| || $inspection_attrs->{ $mapping->{'streetlight'} } |
davea
approved these changes
May 20, 2026
mysociety-pusher
force-pushed
the
5472-dumfries-map-utility-responsible
branch
from
df484a7 to
2ab7167
Compare
If there is a responsibility attribute, set it on the extra hash of an update so it can be passed through to FMS for use in templates. Discussion on ticket about implementing this: mysociety/societyworks#5472
mysociety-pusher
force-pushed
the
5472-dumfries-map-utility-responsible
branch
from
2ab7167 to
e4e8775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a responsibility attribute, set it on the extra hash of an update so it can be passed through to FMS for use in templates.
Discussion on ticket about implementing this:
https://github.com/mysociety/societyworks/issues/5472