Skip to content

No-JS map changes#6013

Open
dracos wants to merge 3 commits into
masterfrom
map-nojs-changes
Open

No-JS map changes#6013
dracos wants to merge 3 commits into
masterfrom
map-nojs-changes

Conversation

@dracos

@dracos dracos commented Jun 10, 2026

Copy link
Copy Markdown
Member

Fixes a bug in a redirect from /report/new to /around where it wasn't remembering the show_old_reports setting.
Replaces the non-JS map control links with buttons that should do the same thing.
And add a file check to allow easy override to OSM mapping should that be needed in future.
[skip changelog]

dracos added 3 commits June 10, 2026 18:44
This should still work basically the same, albeit with the URL not being
updated with the change any longer, and is fundamentally an admission of
defeat against the tidal wave of badly written scrapers spiralling round
and round our maps continuously; this is the world we find ourselves in.
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.41%. Comparing base (45b261f) to head (71ecb2d).

Files with missing lines Patch % Lines
perllib/FixMyStreet/App/Controller/Root.pm 30.00% 6 Missing and 1 partial ⚠️
perllib/FixMyStreet/Cobrand/Default.pm 0.00% 0 Missing and 1 partial ⚠️
perllib/FixMyStreet/TestMech.pm 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6013      +/-   ##
==========================================
- Coverage   83.43%   83.41%   -0.03%     
==========================================
  Files         500      500              
  Lines       37333    37352      +19     
  Branches     6166     6169       +3     
==========================================
+ Hits        31148    31156       +8     
- Misses       4378     4386       +8     
- Partials     1807     1810       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dracos dracos requested a review from neprune June 11, 2026 14:21

@neprune neprune left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants