Show pin legends on map#5977
Open
lucascumsille wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5977 +/- ##
==========================================
- Coverage 83.41% 83.38% -0.03%
==========================================
Files 500 500
Lines 37341 37358 +17
Branches 6167 6167
==========================================
+ Hits 31147 31150 +3
- Misses 4386 4400 +14
Partials 1808 1808 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
Author
|
@dracos I just added some version for mobile(/around and /reports pages) |
Member
|
The design of this supersedes #5586, but that PR's approach to configuring pin colours per-cobrand might be worth using. |
Contributor
Author
|
For tablet I need to add a click for the desktop version. |
3211e7f to
6ff37e0
Compare
- On mobile `around` page is a toggle button inside the map that will display a panel with the legends. - On mobile `` because we don't have the space in the map like we do in `around` page is a drawer. - On desktop and tablet a horizontal slide button will display a panel with the legends.
6ff37e0 to
12fd8be
Compare
Contributor
Author
|
@davea I left this PR ready for review, but it's not really ready for merge. It needs all the back-end changes so we use the pins and legends from each cobrand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/mysociety/societyworks/issues/5466
TODOs
.map_linksTODOs Developer
The only that comes to mind is:
Notes:
pin-legend-wrapper--previewfor something else, for now it seem like a good approach for now. Considering that we have cobrands that use other pins, those previews could be problematic to implement.Desktop
Screen.Recording.2026-06-16.at.06.48.09.mov
Keyboard navigation
Screen.Recording.2026-06-16.at.06.51.46.mov
Mobile
Reports page
Screen.Recording.2026-05-18.at.09.28.23.mov
Around page
Screen.Recording.2026-05-18.at.10.11.05.mov