5427 dispute missed bin report closed#5910
Closed
struan wants to merge 7 commits into
Closed
Conversation
struan
changed the base branch from
master
to
5275-sutton-missed-collection-disputes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 5275-sutton-missed-collection-disputes #5910 +/- ##
==========================================================================
+ Coverage 83.42% 83.43% +0.01%
==========================================================================
Files 500 500
Lines 37409 37527 +118
Branches 6183 6211 +28
==========================================================================
+ Hits 31207 31312 +105
- Misses 4388 4395 +7
- Partials 1814 1820 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
struan
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
2 times, most recently
from
b64cc25 to
ff6c53d
Compare
struan
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
5711e6c to
ee3c15e
Compare
MorayMySoc
approved these changes
Apr 14, 2026
MorayMySoc
left a comment
MorayMySoc
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. Couple of minor notes just highlighting extra empty lines and a typo in explanation
| my $disputes = $events->filter({ event_type => 3143, service => $service_id }); | ||
| my $missed_events = $events->filter({ type => 'missed', service => $service_id }); | ||
| my $missed = $self->{c}->stash->{booked_missed}; | ||
|
|
| $missed->{$guid}{service_id}, | ||
| $missed->{$guid}{report_locked_out_reason} | ||
| ); | ||
|
|
| $missed->{$guid}{event_id} = $missed_event->{id}; | ||
| $missed->{$guid}{report_id} = $missed_event->{report}->id; | ||
| } | ||
| # out original collection was not picked up because of a problem so we |
struan
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
2 times, most recently
from
b52670e to
e5c375a
Compare
dracos
force-pushed
the
5275-sutton-missed-collection-disputes
branch
from
5242605 to
8040dc3
Compare
dracos
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
e5c375a to
8bd816a
Compare
nephila-nacrea
force-pushed
the
5275-sutton-missed-collection-disputes
branch
2 times, most recently
from
14e2963 to
5af0430
Compare
nephila-nacrea
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
8bd816a to
320a16d
Compare
nephila-nacrea
force-pushed
the
5275-sutton-missed-collection-disputes
branch
from
5af0430 to
26fa049
Compare
nephila-nacrea
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
320a16d to
6f50940
Compare
dracos
force-pushed
the
5275-sutton-missed-collection-disputes
branch
from
26fa049 to
6ae1ccc
Compare
dracos
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
5f50c5b to
a93c3e9
Compare
Co-authored-by: Matthew Somerville <matthew@mysociety.org>
dracos
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
a93c3e9 to
657ef50
Compare
This is disputes for when a missed collection has been raised and then the second collection has been attempted but not completed. Fixes mysociety/societyworks#5427
In order to get the details of missed missed collections need to parse all the missed events and stash them instead of only the missed initial collections
Update the alert template to add a link to the dispute form if a missed collection was again missed.
was previously from 6pm on day of collection
dracos
force-pushed
the
5427-dispute-missed-bin-report-closed
branch
from
657ef50 to
a122079
Compare
Member
|
This has been merged somewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is disputes for when a missed collection has been raised and then
the second collection has been attempted but not completed.
Fixes https://github.com/mysociety/societyworks/issues/5427
[skip changelog]