Skip to content

docs(skills): draw the line between the rigs and openrig-skills descr… - #1174

Merged
mvschwarz merged 2 commits into
mvschwarz:mainfrom
ehnruiz:skill-descriptions-boundary
Oct 12, 2026
Merged

mvschwarz merged 2 commits into
mvschwarz:mainfrom
ehnruiz:skill-descriptions-boundary

Conversation

@ehnruiz

@ehnruiz ehnruiz commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1171.

Both descriptions claimed getting a rig back, a watchdog wake and an OpenRig upgrade, and neither named the other, so the wording of the request decided which skill loaded.

The line is drawn by who is asking rather than by topic:

rigs is a person in their own Claude Code or Codex session: install, set up, start, update, re-attach, share a team, join one.
openrig-skills is an agent already running inside a rig: fleet recovery, seat handover, watchdog wakes, in-rig upgrades, and the rest of the index.
Each description now names the other in one clause. Recovery and upgrades stay on both sides on purpose, because "my rig is down" and "upgrade OpenRig" mean different things from each vantage; that is the part of the line most open to moving.

Only the two description lines change. The package copy of rigs, the plugin and _canonical copies of openrig-skills, and scripts/skill-edge-digests.generated.json follow the source edits (node scripts/regen-edge-digests.mjs). npm run test:repo passes, including mirror-skills --check.

Observed on 0.6.8 (aa126c7); the descriptions are unchanged on main at v0.6.9.

Summary by CodeRabbit

  • Documentation
    • Clarified when to use guidance for managing OpenRig from a personal session versus working from inside a running rig.
    • Added clearer routing for installing, starting, updating, or reconnecting to OpenRig, restoring a stopped rig from a personal session, and joining a team.
    • Clarified that in-rig tasks—including fleet recovery, seat handover, watchdog wakes, and upgrades—are covered by the in-rig guidance.

…iptions

Both descriptions claimed getting a rig back, a watchdog wake and an OpenRig
upgrade, and neither named the other, so the wording of the request decided
which skill loaded. The line is now who is asking: rigs is a person in their
own session (install, set up, start, update, re-attach, share, join);
openrig-skills is an agent already inside a rig (fleet recovery, seat
handover, watchdog wakes, in-rig upgrades). Each description names the other
in one clause. The package copy of rigs, the plugin and canonical copies of
openrig-skills, and the edge digests follow the source edits.
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad92ba95-0be1-4cf4-b36e-e31cccfd5bf9

📥 Commits

Reviewing files that changed from the base of the PR and between a159c3e and 772425a.


⛔ Files ignored due to path filters (1)
  • scripts/skill-edge-digests.generated.json is excluded by !**/*.generated.*

📒 Files selected for processing (5)
  • packages/daemon/assets/plugins/openrig-core/skills/openrig-skills/SKILL.md
  • packages/daemon/assets/skills/rigs/SKILL.md
  • packages/daemon/specs/agents/shared/skills/core/openrig-skills/SKILL.md
  • skills/_canonical/core/openrig-skills/SKILL.md
  • skills/rigs/SKILL.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The rigs and openrig-skills descriptions now distinguish session-level tasks from operations performed inside OpenRig. Each description directs those tasks to the corresponding skill.

Changes

Skill routing

Layer / File(s) Summary
Separate session tasks from in-rig operations
packages/daemon/assets/skills/rigs/SKILL.md, skills/rigs/SKILL.md, packages/daemon/assets/plugins/openrig-core/skills/openrig-skills/SKILL.md, packages/daemon/specs/agents/shared/skills/core/openrig-skills/SKILL.md, skills/_canonical/core/openrig-skills/SKILL.md
The rigs descriptions cover recovering stopped teams and re-attaching to agents. They direct in-rig operations, including recovery, handover, watchdog wakes, and upgrades, to openrig-skills. The openrig-skills descriptions direct setup, startup, updates, and re-attachment tasks to rigs.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other · Severity of issue fixed: Medium

Suggested reviewers: mvschwarz


Merge Risk: ⚪ Minimal · up to 77242

The descriptions consistently distinguish person-session setup and recovery from in-rig operations, and their generated digests match. No actionable merge risk remains.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: distinguishing the roles of the rigs and openrig-skills descriptions.
Linked Issues check Passed Issue [#1171] requires a boundary between rigs user-session requests and openrig-skills in-rig requests. The changed descriptions define that boundary. rigs covers setup, start, update, re-attac…
Out of Scope Changes check Passed The reviewed changes update only the two skill descriptions and their synchronized package, plugin, and canonical copies. These changes directly support [#1171]. The reported generated digest update s…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mvschwarz

Copy link
Copy Markdown
Owner

Thanks, @ehnruiz, for following up on #1171 with this. As you describe it, the line is drawn by who's asking (a person in their own Claude Code or Codex session for rigs, an agent already running inside a rig for openrig-skills), and only the two description lines change, with the copies regenerated. We'll review it and follow up here.

@mvschwarz

Copy link
Copy Markdown
Owner

Thanks, @ehnruiz, for turning #1171 into a PR so quickly. Drawing the line by who's asking works well: openrig-skills still covers an agent inside a rig (recovery, handover, upgrades and the rest) and now points to rigs, and the generated copies and the digest match the sources.

One change in rigs: please keep the person's own words and their recovery case.

  • "Getting back to their OpenRig agents" became "re-attaching to their OpenRig agents". "Get back to my agents" is how people ask, and re-attaching is narrower, since it assumes the team is already running. Could you keep "getting back to" alongside it?
  • The new text no longer covers bringing a stopped team back from the person's own session, for example after a reboot, so someone asking that from their own Claude Code or Codex has nothing in rigs that matches. The PR says recovery stays on both sides, and this would make the text say it.

A minimal wording that does both (adjust as you see fit):

…seeing, getting back to or re-attaching to their OpenRig agents (including bringing a stopped team back), TUI or operator, starting or sharing a team, and joining this session to one. Operating a running rig from inside it … is the openrig-skills skill.

Optionally, openrig-skills now says "you are an agent". Our convention for skill descriptions is the third person, for example "Use when an agent running inside OpenRig needs…".

Then regenerate the copies and the digest as before.

…d person in openrig-skills

rigs keeps the person's own words, "getting back to" their agents, next to
re-attaching, and says it covers bringing a stopped team back from their own
session, so recovery is on both sides as the pull request claims.
openrig-skills follows the third-person convention and its pointer back to
rigs uses the same words. Copies and the edge digests regenerated.
@ehnruiz

ehnruiz commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, @ehnruiz, for turning #1171 into a PR so quickly. Drawing the line by who's asking works well: openrig-skills still covers an agent inside a rig (recovery, handover, upgrades and the rest) and now points to rigs, and the generated copies and the digest match the sources.

Done in 772425a. rigs now keeps "getting back to" next to re-attaching and says it includes bringing a stopped team back, using your wording. openrig-skills is in the third person, and its pointer back to rigs names the same cases so recovery reads the same from both sides. Copies and the digest regenerated; npm run test:repo passes.

@openrig-review openrig-review left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 772425a. The rigs and openrig-skills descriptions now divide by who is asking: rigs for a person in their own Claude Code or Codex session (install, start, update, getting back to their agents, bringing a stopped team back), openrig-skills for an agent already running inside a rig. Each names the other in one clause. The generated copies and skill-edge digests match their sources byte for byte. Required CI passed at this head, on a base that already includes main's only later change to these files.

— dev60-planner@v-openrig-build

@mvschwarz
mvschwarz merged commit ada3678 into mvschwarz:main Oct 12, 2026
10 checks passed
@mvschwarz

Copy link
Copy Markdown
Owner

Merged to main, thanks @ehnruiz. It will ship in the next release. Congratulations on your first merged PR here, and thanks for fixing the overlap you reported in #1171, which this closes.

@ehnruiz

ehnruiz commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

Merged to main, thanks @ehnruiz. It will ship in the next release. Congratulations on your first merged PR here, and thanks for fixing the overlap you reported in #1171, which this closes.

Thanks @mvschwarz looking forward to making more contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rigs and openrig-skills descriptions overlap on recovery, watchdog wakes and upgrades

3 participants