Event handling, a couple of extra params and some classes - #2
Open
MattReimer wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I love your keyboard. It's simple, semantically designed and does exactly what I need.... except for a few things.
I added some event handling for KeyPress events:
onKeyClick: corresponds toonclickfor any piano keyonKeyDown: corresponds toonmousedownfor any piano keyonKeyUp: corresponds toonmouseupfor any piano keyI also added a new parameter:
nameOctaveswhich toggles the octave number in the key name.Also there's a new
namesModecalled "both" that allows both sharp and flat to coexist.Then I added some new classes so I can select octaves and also some convenience classes for white and black classes.
Don't feel you need to merge these but I thought they might be useful to give back.
Thanks for making such a great module!