Improvement of MusicMe music provider for API signin, and fix the parsing of the "streamable" fields and playlists ids

[mintgrey]

What does this implement/fix?

This PR adds/corrects 3 functionalities as discussed in Discussion #5421 :

• It adds a method for signin by API call rather than HTTP authentification by website, and a checkbox for user choice is provided at initialisation of the provider by a ConfigEntry entry
• It fixes a problem that leads to unavalaible albums or tracks, by modifying the test on "streamable" fied in JSON response
• It fixes a problem that leads to unplayable playlist, by modifying the way to parse the playlist id to have a full numeric id without an annoying prefix

The modifications are tested locally for several days on my HA/MA installation, and it works like a charm !

Types of changes

• Bugfix (non-breaking change which fixes an issue) — bugfix
• New feature (non-breaking change which adds functionality) — new-feature
• Enhancement to an existing feature — enhancement
• New music/player/metadata/plugin provider — new-provider
• Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
• Refactor (no behaviour change) — refactor
• Documentation only — documentation
• Maintenance / chore — maintenance
• CI / workflow change — ci
• Dependencies bump — dependencies

Checklist

• The code change is tested and works locally.
• pre-commit run --all-files passes.
• pytest passes, and tests have been added/updated under tests/ where applicable.
• For changes to shared models, the companion PR in music-assistant/models is linked.
• For changes affecting the UI, the companion PR in music-assistant/frontend is linked.
• I have read and complied with the project's AI Policy for any AI-assisted contributions.

P.S. This is my first PR on github, I'm listening for any advice or correction !

[MarvinSchenkel]

@JulienDeveaux could you please have a look at this?

[Copilot]

Pull request overview

Improves the existing MusicMe music provider by adding an API-based signin alternative to the existing scraped-web login, broadening the "streamable" filter from == 2 to != 0 so albums/tracks flagged with other non-zero values are not hidden, and stripping the pl- prefix from playlist IDs so the dataservice playlist endpoints work for those entries.

Changes:

• Adds a SIGNIN_BY_API boolean config entry and a new _signin_by_api method that authenticates by hitting /medialibrary/signin via _api_get.
• Replaces all streamable == 2 checks with streamable != 0 in search, browse, recommendations, top tracks, radio track selection, and parsers.
• Normalizes playlist IDs in _parse_playlist by stripping a pl- prefix; updates one streaming test fixture to match the new streamable semantics.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
music_assistant/providers/musicme/constants.py	Adds the SIGNIN_BY_API config key constant.
music_assistant/providers/musicme/init.py	Registers the new boolean config entry for API signin.
music_assistant/providers/musicme/provider.py	Branches init between web login and new _signin_by_api; loosens streamable checks; strips pl- from playlist ids.
tests/providers/musicme/test_streaming.py	Updates a fixture from streamable: 1 to streamable: 0 to match new semantics.

Comments suppressed due to low confidence (1)

music_assistant/providers/musicme/provider.py:60

• [PROBLEM] The import group is no longer alphabetically sorted (SIGNIN_BY_API should come after PARTNER_ID). Ruff/isort in pre-commit will flag this.

from .constants import (
    SIGNIN_BY_API,
    CLIENT_JSON,
    DATASERVICE_BASE,
    LOGIN_URL,
    PARTNER_ID,
    STREAM_BASE,
    VALID_ID_RE,
    WEB_BASE,

[JulienDeveaux]

Hi, I'll take a look next week :)

Linking the discussion : https://github.com/orgs/music-assistant/discussions/5421

[OzGav]

@mintgrey As you address each copilot comment then please add a response

[JulienDeveaux]

Hi @mintgrey,

I did some tests, and it turns out my account on the main domain also work in the SIGNIN_BY_API method.

• /medialibrary/signin returns the same userId as the web playerInit
• streamable: 1 seems to be a better fit than my ==2 which may have caused some song to behave wrongly
• MusicMe seems to resolve the library from the account itself, so it works from whatever domain

I think we can make the previous auth method as a fallback if the SIGNIN_BY_API fails to auth or even remove it.
This would allow to remove the "Signin by API" checkbox that I think was unclear and now unnecessary.

Don't forget to edit / create new tests for the new auth method.

Thank for your work on this 👍

[mintgrey]

Hi @mintgrey,

I did some tests, and it turns out my account on the main domain also work in the SIGNIN_BY_API method.

* `/medialibrary/signin` returns the same `userId` as the web `playerInit`

* `streamable: 1` seems to be a better fit than my ==2 which may have caused some song to behave wrongly

* MusicMe seems to resolve the library from the account itself, so it works from whatever domain

I think we can make the previous auth method as a fallback if the SIGNIN_BY_API fails to auth or even remove it. This would allow to remove the "Signin by API" checkbox that I think was unclear and now unnecessary.

Don't forget to edit / create new tests for the new auth method.

Thank for your work on this 👍

Hi @JulienDeveaux,

Thanks a lot, and good news if it's work more widely than on my only account :) !

Indeed, I've begin an need to continue ASAP to re(re, re)work the PR to properly include each advice from Copilot and to edit the test plan.

For the checkbox, we can maybe put it after the login/password fiels, and explicitely label it as "Web login as fallback method" to keep the previous method "in case of" ?

Stay tuned :)

[JulienDeveaux]

Hi @mintgrey,
I'm not sold on this checkbox.
For me, a user should only input his user / password and the provider should manage the rest

[mintgrey]

OK, I understand.

And just for be sure (and for the beauty of the exercise ;), maybe we can put it only in "advanced" mode ?

[JulienDeveaux]

That's a good compromise I think

[mintgrey]

👍 I will take a look at this !

[OzGav]

I am just going to mark this one as draft so we can keep track of those that need our attention. Please mark as ready for review when you want us to look again.