Skip to content

test: fix TCP port collisions using ephemeral listeners #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glaslos merged 1 commit into from
May 29, 2026
Merged

test: fix TCP port collisions using ephemeral listeners #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 33 additions & 22 deletions connection/connection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,44 @@ import (
"github.com/stretchr/testify/require"
)

var testck = CKey([2]uint64{9580489724559085892, 13327978790310486453})
var localhost1234Key = CKey([2]uint64{9580489724559085892, 13327978790310486453})

func TestNewConnKeyByString(t *testing.T) {
ck, err := NewConnKeyByString("127.0.0.1", "1234")
require.NoError(t, err)
require.Equal(t, testck, ck)
}
func testTCPConn(t *testing.T) (net.Conn, CKey) {
t.Helper()

func TestNewConnKeyFromNetConn(t *testing.T) {
ln, err := net.Listen("tcp4", "127.0.0.1:1234")
ln, err := net.Listen("tcp4", "127.0.0.1:0")
require.NoError(t, err)
require.NotNil(t, ln)
defer ln.Close()
t.Cleanup(func() {
_ = ln.Close()
})

conn, err := net.Dial(ln.Addr().Network(), ln.Addr().String())
require.NoError(t, err)
require.NotNil(t, conn)
defer conn.Close()
t.Cleanup(func() {
_ = conn.Close()
})

host, port, err := net.SplitHostPort(conn.RemoteAddr().String())
require.NoError(t, err)
key, err := NewConnKeyByString(host, port)
require.NoError(t, err)

return conn, key
}

func TestNewConnKeyByString(t *testing.T) {
ck, err := NewConnKeyByString("127.0.0.1", "1234")
require.NoError(t, err)
require.Equal(t, localhost1234Key, ck)
}

func TestNewConnKeyFromNetConn(t *testing.T) {
conn, expected := testTCPConn(t)
ck, err := NewConnKeyFromNetConn(conn)
require.NoError(t, err)
require.Equal(t, testck, ck)
require.Equal(t, expected, ck)
}

func TestNewConnTable(t *testing.T) {
Expand All @@ -43,26 +61,19 @@ func TestRegister(t *testing.T) {
m1, err := table.Register("127.0.0.1", "1234", uint16(targetPort), &rules.Rule{})
require.NoError(t, err)
require.NotNil(t, m1)
m2 := table.Get(testck)
m2 := table.Get(localhost1234Key)
require.NotNil(t, m1)
require.Equal(t, targetPort, int(m2.TargetPort))
require.Equal(t, m1, m2)
}

func TestRegisterConn(t *testing.T) {
ln, err := net.Listen("tcp4", "127.0.0.1:1234")
require.NoError(t, err)
require.NotNil(t, ln)
defer ln.Close()
conn, err := net.Dial(ln.Addr().Network(), ln.Addr().String())
require.NoError(t, err)
require.NotNil(t, conn)
defer conn.Close()
conn, ck := testTCPConn(t)
table := New(context.Background())
md, err := table.RegisterConn(conn, &rules.Rule{Target: "tcp"})
require.NoError(t, err)
require.NotNil(t, md)
m := table.Get(testck)
m := table.Get(ck)
require.NotNil(t, m)
require.Equal(t, "tcp", m.Rule.Target)
}
Expand All @@ -74,6 +85,6 @@ func TestFlushOlderThan(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, md)
table.FlushOlderThan(time.Duration(0))
m := table.Get(testck)
m := table.Get(localhost1234Key)
require.Empty(t, m)
}
4 changes: 2 additions & 2 deletions producer/producer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ func TestProducerLog(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, p)

l, err := net.Listen("tcp", ":1234")
l, err := net.Listen("tcp", "127.0.0.1:0")
require.NoError(t, err)
require.NotNil(t, l)
defer l.Close()
conn, err := net.Dial("tcp", ":1234")
conn, err := net.Dial(l.Addr().Network(), l.Addr().String())
require.NoError(t, err)
require.NoError(t, conn.Close())
md := connection.Metadata{
Expand Down
4 changes: 2 additions & 2 deletions protocols/protocols_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ import (
)

func testConn(t *testing.T) (net.Conn, func() error) {
l, err := net.Listen("tcp", ":1235")
l, err := net.Listen("tcp", "127.0.0.1:0")
require.NoError(t, err)
require.NotNil(t, l)
conn, err := net.Dial("tcp", ":1235")
conn, err := net.Dial(l.Addr().Network(), l.Addr().String())
require.NoError(t, err)
err = conn.SetDeadline(time.Now().Add(time.Millisecond))
require.NoError(t, err)
Expand Down
20 changes: 7 additions & 13 deletions rules/rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func TestInitProxyTCPRuleRejectsInvalidTarget(t *testing.T) {
}

func testConn(t *testing.T) (net.Conn, net.Listener) {
ln, err := net.Listen("tcp", "127.0.0.1:1234")
ln, err := net.Listen("tcp", "127.0.0.1:0")
require.NoError(t, err)
require.NotNil(t, ln)
con, err := net.Dial(ln.Addr().Network(), ln.Addr().String())
Expand All @@ -159,17 +159,14 @@ func TestFakePacketBytes(t *testing.T) {
func TestRunMatchTCP(t *testing.T) {
rules := parseRules(t)
require.NotEmpty(t, rules)
conn, ln := testConn(t)
defer func() {
conn.Close()
ln.Close()
}()
var (
match *Rule
err error
)

match, err = rules.Match("tcp", conn.LocalAddr(), conn.RemoteAddr())
srcAddr := &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 50000}
dstAddr := &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 1234}
match, err = rules.Match("tcp", srcAddr, dstAddr)
require.NoError(t, err)
require.NotNil(t, match)
require.Equal(t, "test", match.Target)
Expand All @@ -178,17 +175,14 @@ func TestRunMatchTCP(t *testing.T) {
func TestRunMatchUDP(t *testing.T) {
rules := parseRules(t)
require.NotEmpty(t, rules)
conn, ln := testConn(t)
defer func() {
conn.Close()
ln.Close()
}()
var (
match *Rule
err error
)

match, err = rules.Match("udp", conn.LocalAddr(), conn.RemoteAddr())
srcAddr := &net.UDPAddr{IP: net.ParseIP("127.0.0.1"), Port: 50000}
dstAddr := &net.UDPAddr{IP: net.ParseIP("127.0.0.1"), Port: 1234}
match, err = rules.Match("udp", srcAddr, dstAddr)
require.NoError(t, err)
require.NotNil(t, match)
require.Equal(t, "test", match.Target)
Expand Down
Loading