Skip to content

Flatten template directory structure? #536

Description

@srenfo

For simplifications beyond #534 the template directories could be flattened a bit.

Currently:

conpot/templates
├── default
│   ├── bacnet
│   │   └── bacnet.xml
│   ├── enip
│   │   └── enip.xml
│   ├── ftp
│   │   └── ftp.xml
│   ├── http
│   │   ├── htdocs
│   │   │   ├── tests
│   │   │   └── ...
│   │   ├── statuscodes
│   │   │   └── ...
│   │   └── http.xml
│   ├── ipmi
│   │   └── ipmi.xml
│   ├── ...
│   └── template.xml
...

Suggestion: Move the protocol XMLs up by one level. Keep the subdirectories for protocols that want auxiliary files.

conpot/templates
├── default
│   ├── bacnet.xml
│   ├── enip.xml
│   ├── ftp.xml
│   ├── http
│   │   ├── htdocs
│   │   │   ├── tests
│   │   │   └── ...
│   │   ├── statuscodes
│   │   │   └── ...
│   ├── http.xml
│   ├── ipmi.xml
│   ├── ...
│   └── template.xml
...

Pros: Easier to navigate and thus easier to modify and to keep track of.

Cons: It may look odd to have both an http.xml and an http directory. Also, template.xml is now on the same level as the protocol XMLs despite being one level above them hierarchically.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions