Fix some text type's offsets when migrating scores to 4.7#33590
Open
miiizen wants to merge 1 commit into
Open
Conversation
mike-spa
reviewed
May 27, 2026
| // Text offset could have been in mm for these types prior to 4.7 | ||
| // Convert actual distance to spatium | ||
| if ((item->isFingering() || item->isHammerOnPullOffText() || item->isLyrics() || !item->isMeasureNumber() | ||
| || item->isStaffText() || item->isTapping()) && !item->sizeIsSpatiumDependent()) { |
Contributor
There was a problem hiding this comment.
Better to define an unordered_map with these types and use muse::contains to avoid the chain of ||.
4 tasks
miiizen
force-pushed
the
33584-text-migration-47
branch
from
45857ac to
6df459c
Compare
miiizen
force-pushed
the
33584-text-migration-47
branch
from
6df459c to
e8b7391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #33584
This PR adds the compatibility missed in #31187.
For lyrics, fingering, HOPO text, measure numbers, staff text and tapping, when "Scale with stave size" was ticked offset was expressed in mm not spatium. In 4.7 for these types, offsets are always in spatium.