Port engraving PRs to 4.7.3#33585
Open
miiizen wants to merge 11 commits into
Open
Conversation
The deleted frame would still be referenced by the System that contained it, and that System would be deleted from its Page’s list of systems, but not from the Score’s list of systems. Lucky enough, that seems not to cause crashes normally (as far as I know), but upon closing the score, it does cause a crash: the deleted frame is destroyed by the UndoStack (correctly so), but when the frame's System is destroyed as part of the Score destruction, the deleted frame is referenced again. Solution: properly remove the System’s reference to the frame, and also properly remove the System and its Page when they become empty. This brings the code in line with `InsertRemoveMeasures::removeMeasures()`. Resolves: musescore#33518
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports: #33356
Ports: #33350
Ports: #32557
Ports: #33260
Ports: #33168
Ports: #33556
Ports: #33540
Ports: #33593