Fix header/footer timestamps update on file save#33579
Merged
Merged
Conversation
4 tasks
ajuncosa
force-pushed
the
fix-header-footer-timestamps
branch
from
624b26b to
c2299d8
Compare
mike-spa
approved these changes
Jun 1, 2026
ajuncosa
force-pushed
the
fix-header-footer-timestamps
branch
2 times, most recently
from
89805e8 to
a57cdcc
Compare
… renderer as a dependency in NotationProject directly to decouple DOM and layout, and remove intermediate calls between renderer and ScorePageViewLayout
…ut and redraw of all excerpts if not necessary
ajuncosa
force-pushed
the
fix-header-footer-timestamps
branch
from
16350cf to
870f4a3
Compare
mike-spa
approved these changes
Jun 3, 2026
Contributor
|
@ajuncosa Tested and approved on Ubuntu 24.04.4 LTS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #33345
In order to be able to update the timestamps when saving the file, I have added and exposed some functions to layout the headers and footers only, to avoid doing a full re-layout when saving the file. Timestamps are now only updated on save instead of on modifications to the score.