Fix #33553: Allow Style System page to resize vertically#33562
Fix #33553: Allow Style System page to resize vertically#33562officialasishkumar wants to merge 1 commit into
Conversation
Wrap the System page in the Style dialog with a scroll area so the page no longer forces the dialog above the available screen height on scaled displays. Resolves: musescore#33553
fb3ae9d to
49acc44
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request adds a scrollable container to the PageSystem page of the EditStyle UI dialog. A new 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Is this AI-generated? For editing |
Resolves: #33553
The System page in Format > Style used a plain page widget, so its full size hint became the dialog minimum height. This wraps the page contents in a frameless scroll area, matching other tall Style pages, so the dialog can resize vertically while all controls stay reachable.
Validation:
xmllint --noout src/notationscene/widgets/editstyle.uigit diff --checkI signed the CLA
The title of the PR describes the problem it addresses
Each commit's message describes its purpose and effects, and references the issue it resolves
If changes are extensive, there is a sequence of easily reviewable commits
The code in the PR follows the coding rules
There are no unnecessary changes
The code compiles and runs on my machine, preferably after each commit individually
I created a unit test or vtest to verify the changes I made (if applicable)