Skip to content

Fix #33553: Allow Style System page to resize vertically#33562

Open
officialasishkumar wants to merge 1 commit into
musescore:mainfrom
officialasishkumar:fix-style-system-dialog-resize
Open

Fix #33553: Allow Style System page to resize vertically#33562
officialasishkumar wants to merge 1 commit into
musescore:mainfrom
officialasishkumar:fix-style-system-dialog-resize

Conversation

@officialasishkumar
Copy link
Copy Markdown

Resolves: #33553

The System page in Format > Style used a plain page widget, so its full size hint became the dialog minimum height. This wraps the page contents in a frameless scroll area, matching other tall Style pages, so the dialog can resize vertically while all controls stay reachable.

Validation:

  • xmllint --noout src/notationscene/widgets/editstyle.ui

  • git diff --check

  • I signed the CLA

  • The title of the PR describes the problem it addresses

  • Each commit's message describes its purpose and effects, and references the issue it resolves

  • If changes are extensive, there is a sequence of easily reviewable commits

  • The code in the PR follows the coding rules

  • There are no unnecessary changes

  • The code compiles and runs on my machine, preferably after each commit individually

  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Wrap the System page in the Style dialog with a scroll area so the page no longer forces the dialog above the available screen height on scaled displays.

Resolves: musescore#33553
@officialasishkumar officialasishkumar force-pushed the fix-style-system-dialog-resize branch from fb3ae9d to 49acc44 Compare May 24, 2026 21:40
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 24, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8617e0f-a917-4e42-b01d-0b2ab8ed803b

📥 Commits

Reviewing files that changed from the base of the PR and between 81d6e24 and 49acc44.

📒 Files selected for processing (1)
  • src/notationscene/widgets/editstyle.ui

📝 Walkthrough

Walkthrough

This pull request adds a scrollable container to the PageSystem page of the EditStyle UI dialog. A new QScrollArea widget named scrollArea_system is introduced with an internal layout structure (verticalLayout_system) to host system-related controls. The widget hierarchy is properly closed with updated XML tags, and the scroll area is registered in the dialog's keyboard tab stop order to ensure proper focus navigation.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: fixing the vertical resizability of the Style System page dialog by referencing issue #33553.
Description check ✅ Passed The description includes issue reference, clear motivation, and completion of key checklist items. Missing CLA signature and compilation verification are non-critical.
Linked Issues check ✅ Passed The changes directly address issue #33553 by wrapping the System page contents in a frameless scroll area to allow vertical resizing of the dialog.
Out of Scope Changes check ✅ Passed All changes are contained to the editstyle.ui file and directly relate to the objective of adding scroll area support for vertical resizing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mathesoncalum mathesoncalum self-requested a review May 25, 2026 07:01
@avvvvve avvvvve self-requested a review May 26, 2026 14:21
@cbjeukendrup
Copy link
Copy Markdown
Collaborator

Is this AI-generated? For editing .ui files, it's better to use Qt's official "Designer" application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MSS 5 Nightly] Format -> Style -> System is not vertically resizable

4 participants