Revamp audio plugins module

[luapmartin]

Framework PR: musescore/muse_framework#47
Audacity PR: audacity/audacity#10989

Adapt MuseScore to the revamped muse::audioplugins framework.

• Call sites match the framework's audio↔audioplugins split. Code that handles plugin-cache values uses audioplugins::PluginMeta / PluginResourceId (project audio settings, the audioplugins app-config module, the playback menu-id parsers); code that handles audio-engine values uses audio::AudioResourceMeta and the local audio::intAttribute / boolAttribute helpers (drumsetloader, percussionpanelmodel).

• App-side bridge src/playback/internal/audiometabridge.{h,cpp} — toAudioMeta(const audioplugins::PluginMeta&) / toPluginMeta(const audio::AudioResourceMeta&) and list variants, documenting the audio↔audioplugins seam. Current call sites work within a single domain at a time so the bridge isn't exercised yet; it's there for future divergence between the two struct types.

• New app-side AudioPluginsAppConfigModule registers the v2→v3 known_audio_plugins.json migration — lifts the legacy hasNativeEditorSupport boolean into meta.attributes. (The framework auto-registers v0→v1 and v1→v2.)

• Uses audio::isResourceType() / typed helpers across playback, project, and notation-scene instead of direct comparisons against the AudioResourceType enum.

• hasNativeEditorSupport is not a struct field — it lives in meta.attributes. projectaudiosettings doesn't write it to the saved JSON and migrates the legacy field on load, so existing project files still open.

• CATEGORIES_ATTRIBUTE lives in the vst namespace (it is VST-specific).

• Bumps the muse submodule to the shared framework branch.

• I signed the CLA

• The title of the PR describes the problem it addresses

• Each commit's message describes its purpose and effects, and references the issue it resolves

• If changes are extensive, there is a sequence of easily reviewable commits

• The code in the PR follows the coding rules

• There are no unnecessary changes

• The code compiles and runs on my machine, preferably after each commit individually

• I created a unit test or vtest to verify the changes I made (if applicable)

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a new AudioPluginsAppConfigModule (implementation, header, build inclusion) and registers it in app initialization. The module sets runtime default audio-resource attributes and registers a v2→v3 migration that moves legacy top-level hasNativeEditorSupport into attributes. The changebase replaces direct resource-type and attribute accesses with helper APIs (isResourceType, resourceTypeFromString, intAttribute, hasNativeEditorSupport), updates VST attribute keys, and makes ProjectAudioSettings use audioplugins::AudioResourceType and corresponding JSON import/export adjustments.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title "Revamp audio plugins module" directly reflects the main objective of the PR, which adapts MuseScore to a revamped muse::audioplugins framework with significant architectural changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	PR description is comprehensive with clear explanations of changes, corresponding framework PR links, and all checklist items completed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

src/app/internal/audiopluginsappconfigmodule.cpp (2)

71-77: 💤 Low value

Minor: migration overwrites any pre-existing hasNativeEditorSupport in attributes.

If a v2 record already has the key in meta.attributes (e.g., from manual editing or partial migration), this code unconditionally replaces it with the legacy top-level value. Probably acceptable since legacy v2 data shouldn't have populated this attribute, but consider guarding with if (!attrs.contains("hasNativeEditorSupport")) to be defensive.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/internal/audiopluginsappconfigmodule.cpp` around lines 71 - 77, The
migration unconditionally overwrites meta.attributes["hasNativeEditorSupport"];
modify the block that reads meta and sets attrs (variables meta and attrs, and
the bool b derived from meta.value("hasNativeEditorSupport")) to only set
attrs.set("hasNativeEditorSupport", ...) when attrs does not already contain
that key (i.e., wrap the attrs.set call in if
(!attrs.contains("hasNativeEditorSupport")) so existing v2 attributes are
preserved), then write attrs back to meta as before.

---

65-92: ⚡ Quick win

Use audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE for the JSON key in the v2→v3 migration

src/app/internal/audiopluginsappconfigmodule.cpp writes the attribute under the literal "hasNativeEditorSupport", while src/project/internal/projectaudiosettings.cpp reads/migrates it using audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE. Replace the hard-coded occurrences in the migration with the shared constant (using the appropriate conversion/type for muse::JsonObject keys) to prevent silent drift.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/internal/audiopluginsappconfigmodule.cpp` around lines 65 - 92, The
migration lambda registered via migrations->registerMigration (v2→v3) currently
uses the hard-coded key "hasNativeEditorSupport"; change all occurrences to use
the shared constant audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE (convert it to
the appropriate std::string type if necessary) when calling meta.contains(...),
meta.value(...).toBool(), attrs.set(...), and when filtering keys into
metaWithoutLegacy so the legacy key is removed by comparing against that
constant rather than the literal.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/app/internal/audiopluginsappconfigmodule.cpp`:
- Around line 71-77: The migration unconditionally overwrites
meta.attributes["hasNativeEditorSupport"]; modify the block that reads meta and
sets attrs (variables meta and attrs, and the bool b derived from
meta.value("hasNativeEditorSupport")) to only set
attrs.set("hasNativeEditorSupport", ...) when attrs does not already contain
that key (i.e., wrap the attrs.set call in if
(!attrs.contains("hasNativeEditorSupport")) so existing v2 attributes are
preserved), then write attrs back to meta as before.
- Around line 65-92: The migration lambda registered via
migrations->registerMigration (v2→v3) currently uses the hard-coded key
"hasNativeEditorSupport"; change all occurrences to use the shared constant
audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE (convert it to the appropriate
std::string type if necessary) when calling meta.contains(...),
meta.value(...).toBool(), attrs.set(...), and when filtering keys into
metaWithoutLegacy so the legacy key is removed by comparing against that
constant rather than the literal.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8146db70-bf03-4abb-ba77-be7a898068bc

📥 Commits

Reviewing files that changed from the base of the PR and between 526b45f and ebccb36.

📒 Files selected for processing (14)

• muse
• src/app/CMakeLists.txt
• src/app/appfactory.cpp
• src/app/internal/audiopluginsappconfigmodule.cpp
• src/app/internal/audiopluginsappconfigmodule.h
• src/converter/internal/compat/notationmeta.cpp
• src/notationscene/qml/MuseScore/NotationScene/percussionpanel/percussionpanelmodel.cpp
• src/playback/internal/drumsetloader.cpp
• src/playback/internal/playbackcontroller.cpp
• src/playback/internal/soundprofilesrepository.cpp
• src/playback/qml/MuseScore/Playback/inputresourceitem.cpp
• src/playback/qml/MuseScore/Playback/outputresourceitem.cpp
• src/project/internal/projectaudiosettings.cpp
• src/project/internal/projectaudiosettings.h

[coderabbitai]

🧹 Nitpick comments (1)

src/app/internal/audiopluginsappconfigmodule.cpp (1)

70-77: ⚡ Quick win

Use the shared attribute key constant instead of hard-coded "hasNativeEditorSupport".

This migration should use the same shared key constant used elsewhere to avoid future key drift between migrations and runtime reads.

♻️ Proposed fix

-                if (meta.contains("hasNativeEditorSupport")) {
+                if (meta.contains(muse::audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE)) {
                     muse::JsonObject attrs;
                     if (meta.contains("attributes")) {
                         attrs = meta.value("attributes").toObject();
                     }
-                    const bool b = meta.value("hasNativeEditorSupport").toBool();
-                    attrs.set("hasNativeEditorSupport", b ? std::string("true") : std::string("false"));
+                    const bool b = meta.value(muse::audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE).toBool();
+                    attrs.set(muse::audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE, b ? std::string("true") : std::string("false"));
                     meta.set("attributes", attrs);
@@
-                        if (k == "hasNativeEditorSupport") {
+                        if (k == muse::audio::HAS_NATIVE_EDITOR_SUPPORT_ATTRIBUTE) {
                             continue;
                         }

Also applies to: 82-83

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/internal/audiopluginsappconfigmodule.cpp` around lines 70 - 77, The
code uses the literal "hasNativeEditorSupport" in meta.contains, attrs.set and
meta.set; replace that hard-coded string with the shared attribute key constant
used by the project (the same symbol other modules use for this attribute) —
import or reference that constant (e.g.
SharedAttributeKeys::HasNativeEditorSupport or the existing
HAS_NATIVE_EDITOR_SUPPORT constant used elsewhere) and use it in
meta.contains(...), attrs.set(..., ...), and wherever the literal appears
(including the other occurrence around the attrs handling) so migration and
runtime use the same key.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/app/internal/audiopluginsappconfigmodule.cpp`:
- Around line 70-77: The code uses the literal "hasNativeEditorSupport" in
meta.contains, attrs.set and meta.set; replace that hard-coded string with the
shared attribute key constant used by the project (the same symbol other modules
use for this attribute) — import or reference that constant (e.g.
SharedAttributeKeys::HasNativeEditorSupport or the existing
HAS_NATIVE_EDITOR_SUPPORT constant used elsewhere) and use it in
meta.contains(...), attrs.set(..., ...), and wherever the literal appears
(including the other occurrence around the attrs handling) so migration and
runtime use the same key.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b93e90cf-916e-4c3f-96e4-6bb63f3694ac

📥 Commits

Reviewing files that changed from the base of the PR and between d75af1c and aab1ac6.

📒 Files selected for processing (14)

• muse
• src/app/CMakeLists.txt
• src/app/appfactory.cpp
• src/app/internal/audiopluginsappconfigmodule.cpp
• src/app/internal/audiopluginsappconfigmodule.h
• src/converter/internal/compat/notationmeta.cpp
• src/notationscene/qml/MuseScore/NotationScene/percussionpanel/percussionpanelmodel.cpp
• src/playback/internal/drumsetloader.cpp
• src/playback/internal/playbackcontroller.cpp
• src/playback/internal/soundprofilesrepository.cpp
• src/playback/qml/MuseScore/Playback/inputresourceitem.cpp
• src/playback/qml/MuseScore/Playback/outputresourceitem.cpp
• src/project/internal/projectaudiosettings.cpp
• src/project/internal/projectaudiosettings.h

✅ Files skipped from review due to trivial changes (2)

• src/playback/internal/soundprofilesrepository.cpp
• src/project/internal/projectaudiosettings.cpp