Skip to content

Add extra check for competing proof + sort by nonce on ring buffer#7891

Open
sstanculeanu wants to merge 2 commits into
feat/testnet-fixesfrom
medium-findings
Open

Add extra check for competing proof + sort by nonce on ring buffer#7891
sstanculeanu wants to merge 2 commits into
feat/testnet-fixesfrom
medium-findings

Conversation

@sstanculeanu

Copy link
Copy Markdown
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Jun 25, 2026
@sstanculeanu sstanculeanu added the type:bug Something isn't working label Jun 25, 2026
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.64%. Comparing base (0f0c82c) to head (a8fb98e).

Files with missing lines Patch % Lines
consensus/spos/bls/v2/subroundEndRound.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/testnet-fixes    #7891   +/-   ##
===================================================
  Coverage               77.63%   77.64%           
===================================================
  Files                     885      885           
  Lines                  125570   125574    +4     
===================================================
+ Hits                    97490    97504   +14     
+ Misses                  21590    21580   -10     
  Partials                 6490     6490           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant