when transitioning to Andromeda, request missing proofs#7890
Open
BeniaminDrasovean wants to merge 2 commits into
Open
when transitioning to Andromeda, request missing proofs#7890BeniaminDrasovean wants to merge 2 commits into
BeniaminDrasovean wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sstanculeanu
previously approved these changes
Jun 25, 2026
AdoAdoAdo
reviewed
Jun 25, 2026
| for index := range headers { | ||
| bp.hdrsForCurrBlock.hdrHashAndInfo[string(headersHashes[index])] = &hdrInfo{ | ||
| hdr: headers[index], | ||
| hdrHash := headersHashes[index] |
Contributor
There was a problem hiding this comment.
was there a reason to do an alloc here instead of using the value directly besides readability?
Contributor
Author
There was a problem hiding this comment.
No, changed.
sstanculeanu
approved these changes
Jun 25, 2026
AdoAdoAdo
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes an edge case in metachain/shard-header finality attestation sync where a finality-attesting header is already available locally, but its equivalent proof is missing.
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?