Switch protoc for protox#10437
Draft
MarkusPettersson98 wants to merge 2 commits into
Draft
Conversation
MarkusPettersson98
force-pushed
the
upgrade-tonic
branch
2 times, most recently
from
a560e81 to
2b15bf9
Compare
MarkusPettersson98
force-pushed
the
drop-protoc-requirement
branch
2 times, most recently
from
880dd21 to
ebb4045
Compare
Add `protox` as a build-time dependency for compiling .proto files. This allow us to drop the dependency on the external `protoc` binary in order to build the workspace crates that include protobuf defintions.
MarkusPettersson98
force-pushed
the
drop-protoc-requirement
branch
from
bf77253 to
e43abe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps out
protocfor protox, as pure Rust implementation of a protobuf compiler. This allows us to add it as a build-time dependency in the crates where we compile .proto files, and we can get rid ofprotocas a dependency. This is nice, since build/dev environments do not need to installprotocanymore (Thus invalidating #10431, for example).Blocked on grpc/grpc-rust#2647.
This change is