Skip to content

W-23708419: Actually exclude TCK conformance on PR builds via scalatest tag #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlischetti merged 1 commit into from
Aug 5, 2026
Merged

W-23708419: Actually exclude TCK conformance on PR builds via scalatest tag #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions native-cli-integration-tests/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,16 @@ downloadTestSuites.dependsOn(cleanTestSuites)
test.dependsOn(downloadTestSuites)
test.dependsOn(":native-cli:nativeCompile")

// Skip TCKCliTest when -PskipTCKTests=true (matches -PskipNodeTests pattern).
// CI build-foundation passes this flag on non-master branches so TCK only runs via the explicit
// "Run CLI TCK Conformance" step (master-only), matching Node TCK behavior. Other IT tests run always.
// TCK conformance is master-only. On non-master CI, build-foundation passes
// -PskipTCKTests=true; we exclude the TckConformance-tagged scenarios so they
// don't run, while the module's other IT specs still do. This uses ScalaTest
// tag exclusion (maiflai's `tags { exclude }` -> scalatest `-l <tag>`) rather
// than Gradle's Test.exclude class-pattern filter, which is a no-op under the
// maiflai scalatest runner. Mirrors the master-only Node TCK lane.
test {
if (project.hasProperty('skipTCKTests') && project.property('skipTCKTests') == 'true') {
exclude '**/TCKCliTest.class'
tags {
exclude 'org.mule.weave.clinative.TckConformance'
}
}
}
7 changes: 6 additions & 1 deletion native-cli-integration-tests/src/test/scala/org/mule/weave/clinative/TCKCliTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import org.apache.commons.io.FilenameUtils
import org.mule.weave.v2.helper.FolderBasedTest
import org.mule.weave.v2.utils.DataWeaveVersion
import org.mule.weave.v2.version.ComponentVersion
import org.scalatest.Tag
import org.scalatest.funspec.AnyFunSpec
import org.scalatest.matchers.should.Matchers

Expand All @@ -18,6 +19,10 @@ import java.util.regex.Pattern
import java.util.zip.ZipFile
import scala.collection.JavaConverters._

// TCK conformance scenarios are tagged so CI can exclude them on non-master
// (PR) builds via -PskipTCKTests=true, matching the master-only Node TCK lane.
object TckConformance extends Tag("org.mule.weave.clinative.TckConformance")

class TCKCliTest extends AnyFunSpec with Matchers
with FolderBasedTest
with ResourceResolver
Expand Down Expand Up @@ -142,7 +147,7 @@ class TCKCliTest extends AnyFunSpec with Matchers
val scenarios = unsortedScenarios.sortBy(_.name)
scenarios.foreach {
scenario =>
it(scenario.name) {
it(scenario.name, TckConformance) {
var args = Array("run")

// Add inputs
Expand Down
Loading