docs: explain moving documents between databases - #622
Merged
Conversation
Owner
|
Thanks for the PR, @uadhran! Could you rebase this on the latest master so we can see what the CI pipeline says? |
Document that Document instances retain their doc_id when inserted into another table or database, and show the dict(document) workaround from issue msiemens#354. Add test_move_document_between_tables to cover the conflict and fix. Related: msiemens#354
uadhran
force-pushed
the
docs/354-move-documents
branch
from
August 10, 2026 05:33
d55b7cf to
4a5a77c
Compare
Contributor
Author
|
Rebased onto latest master so CI can run. Conflict with the merged #621 test was resolved by keeping both tests. |
Table.get returns Document | None; narrow the type so mypy accepts insert/dict(document) on Python 3.14 CI.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents returned from TinyDB are
Documentwrappers that retain theirdoc_id. Inserting them into another table or database reuses that ID andcan raise
ValueErrorif the target already has that ID.This documents the
dict(document)workaround described by the maintainerin #354.
Changes
docs/usage.rsttest_move_document_between_tablescovering the doc_id conflict and fixVerification
uv run py.test -v --cov=tinydb— 218 passeduv run py.test -v --pycodestyle— not run (pre-existing failures on master)Related: #354