Skip to content

Fix/promise task declaration order - #1475

Draft
patrickkabwe wants to merge 2 commits into
mrousavy:mainfrom
patrickkabwe:fix/promise-task-declaration-order
Draft

Fix/promise task declaration order#1475
patrickkabwe wants to merge 2 commits into
mrousavy:mainfrom
patrickkabwe:fix/promise-task-declaration-order

Conversation

@patrickkabwe

@patrickkabwe patrickkabwe commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Follow up of #1474

AssertPromiseState.hpp and Promise.hpp include each other, and PromiseTask was declared after the #include "Promise.hpp". That works only when Promise.hpp is entered first true when both are reached through a .cpp, but not when a build system compiles the module's public headers as a clang module and enters AssertPromiseState.hpp first. Promise.hpp's body is then parsed before the enum exists:

Promise.hpp:102:31: error: use of undeclared identifier 'PromiseTask'

Move the declaration up next to the class Promise forward declaration it belongs with, so the header is valid whichever one is entered first.

@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

@patrickkabwe is attempting to deploy a commit to the Margelo Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant