Update image source references to use .src property for consistency… - #28
Merged
Conversation
… across components and optimize privacy notice mounting logic with `queueMicrotask` for improved performance.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Updated image source references in `page.tsx`, `app-shell.tsx`, and `footer.tsx` to use relative paths instead of absolute paths for better consistency and maintainability.
- Introduced `images.d.ts` to declare modules for `.png`, `.jpg`, and `.jpeg` file types, ensuring proper type checking for image imports. - Updated image import paths in `page.tsx`, `app-shell.tsx`, and `footer.tsx` to use absolute paths for consistency and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor but important adjustments to how images are imported and displayed throughout the app, as well as a small update to the privacy notice component to ensure state updates are scheduled more safely. The main focus is on improving compatibility and reliability with image sources and React state updates.
Image handling improvements:
Imagecomponent to use the.srcproperty of imported image objects (e.g.,Logo.srcandIcon.src) instead of passing the object directly. This change affectsapp/page.tsx,components/app-shell.tsx, andcomponents/footer.tsx, and helps prevent potential issues with how images are handled by the framework. [1] [2] [3]State update safety in privacy notice:
components/privacy-notice.tsxto usequeueMicrotask, ensuring thatsetMountedandsetOpenare executed in a microtask, which can help avoid certain React state update warnings or issues.… across components and optimize privacy notice mounting logic withqueueMicrotaskfor improved performance.