Skip to content

Ensure fxci DAG failures reach more people than just me #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahal wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −2
Open

Ensure fxci DAG failures reach more people than just me #2387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc1b033
fix: enable Slack notifications for fxci DAGs
ahal May 21, 2026
ee8c7ec
fix: ensure failure e-mails reach all of releng
ahal May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dags/fxci_metric_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,18 @@

from airflow import DAG
from airflow.providers.cncf.kubernetes.secret import Secret
from airflow.providers.slack.notifications.slack import send_slack_notification

from operators.gcp_container_operator import GKEPodOperator
from utils.tags import Tag

SLACK_FAILURE_NOTIFICATION = send_slack_notification(
text="DAG {{ dag.dag_id }} failed: <{{ task_instance.log_url }}|view log>",
username="airflow-bot",
slack_conn_id="slack_airflow_bot",
channel="#fxci-etl",
)

default_args = {
"owner": "ahalberstadt@mozilla.com",
"depends_on_past": False,
Expand All @@ -20,6 +28,7 @@
"email_on_retry": False,
"retries": 1,
"retry_delay": timedelta(minutes=30),
"on_failure_callback": SLACK_FAILURE_NOTIFICATION,
}

tags = [Tag.ImpactTier.tier_3]
Expand Down Expand Up @@ -68,7 +77,7 @@
gcp_conn_id="google_cloud_airflow_gke",
dag=dag,
email=[
"ahalberstadt@mozilla.com",
"release+fxci-etl@mozilla.com",
"telemetry-alerts@mozilla.com",
],
)
11 changes: 10 additions & 1 deletion dags/fxci_pulse_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,18 @@

from airflow import DAG
from airflow.providers.cncf.kubernetes.secret import Secret
from airflow.providers.slack.notifications.slack import send_slack_notification

from operators.gcp_container_operator import GKEPodOperator
from utils.tags import Tag

SLACK_FAILURE_NOTIFICATION = send_slack_notification(
text="DAG {{ dag.dag_id }} failed: <{{ task_instance.log_url }}|view log>",
username="airflow-bot",
slack_conn_id="slack_airflow_bot",
channel="#fxci-etl",
)

default_args = {
"owner": "ahalberstadt@mozilla.com",
"depends_on_past": False,
Expand All @@ -23,6 +31,7 @@
"email_on_retry": False,
"retries": 1,
"retry_delay": timedelta(minutes=30),
"on_failure_callback": SLACK_FAILURE_NOTIFICATION,
}

tags = [Tag.ImpactTier.tier_3]
Expand Down Expand Up @@ -71,7 +80,7 @@
gcp_conn_id="google_cloud_airflow_gke",
dag=dag,
email=[
"ahalberstadt@mozilla.com",
"release+fxci-etl@mozilla.com",
"telemetry-alerts@mozilla.com",
],
)