Bug 2053531 - Add nimbus-fml lint - #7563
Open
travis79 wants to merge 1 commit into
Open
Conversation
Adds a lint command covering feature metadata, descriptions, naming and feature design, and a `no-lint` field to silence lints per feature or per file. `validate` no longer reports feature metadata warnings; that's the lint command's job now.
jeddai
reviewed
Aug 26, 2026
Comment on lines
+341
to
+345
| let mut raw = Vec::new(); | ||
| metadata::check_feature(feature, &mut raw); | ||
| documentation::check_feature(feature, &mut raw); | ||
| naming::check_feature(feature, &mut raw); | ||
| design::check_feature(feature, fm, &mut raw); |
Member
There was a problem hiding this comment.
Adding these feels like something that could get missed when adding new linting files. Could it be at all viable to instead have the methods be on a trait? Then have the trait get impl'd on structs for each lint type, and have each section iterate through the types and call the appropriate methods?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lint command covering feature metadata, descriptions, naming and feature design, and a
no-lintfield to silence lints per feature or per file.validateno longer reports feature metadata warnings; that's the lint command's job now.Pull Request checklist
[ci full]to the PR title.