Skip to content

V1.1.16 tmc #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willyraedy wants to merge 4 commits into
base: v1.1.15-tmc
Choose a base branch
from
Open

V1.1.16 tmc #26

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
361cad9
fix survey response noin
willyraedy Nov 12, 2025
d71b38d
fix parent commitee typo
willyraedy Nov 12, 2025
2a6c6c8
fix typo
willyraedy Nov 12, 2025
762d008
typo
willyraedy Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions models/intermediate/ngpvan/int_ngpvan__01__survey_responses.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ WITH
committee_name,
committee_short_name,
committee_type,
parent_committee_id,
segment_by
FROM {{ ref("stg_ngpvan__committees") }}
),
Expand Down Expand Up @@ -105,22 +106,27 @@ WITH
contacts.segment_by
{{ ngpvan__int__additional_fields() }}
FROM contacts
LEFT JOIN committees
ON committees.committee_id = contacts.committee_id
LEFT JOIN responses
ON contacts.survey_question_id = responses.survey_question_id
AND contacts.survey_response_id = responses.survey_response_id
AND contacts.committee_id = responses.survey_response_committee_id
AND contacts.segment_by = responses.segment_by
AND (
contacts.committee_id = responses.survey_response_committee_id
OR committees.parent_committee_id = responses.survey_response_committee_id

@mxskylar mxskylar Nov 12, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there grandparents or great grandparent committee relations?

)
LEFT JOIN questions
ON contacts.survey_question_id = questions.survey_question_id
AND contacts.committee_id = questions.survey_question_committee_id
AND contacts.segment_by = questions.segment_by
LEFT JOIN committees
ON (committees.committee_id = COALESCE(contacts.committee_id, questions.survey_question_committee_id, responses.survey_response_committee_id))
AND committees.segment_by = contacts.segment_by
AND (
contacts.committee_id = questions.survey_question_committee_id
OR committees.parent_committee_id = questions.survey_question_committee_id
)
LEFT JOIN campaigns
ON contacts.campaign_id = campaigns.campaign_id
AND contacts.committee_id = campaigns.committee_id
AND contacts.segment_by = campaigns.segment_by
AND (
contacts.committee_id = campaigns.committee_id
OR committees.parent_committee_id = campaigns.committee_id
)
)

SELECT * FROM survey_responses