Skip to content

fix(manager): remove stale plugins with missing directories#481

Merged
gschier merged 3 commits into
mountain-loop:mainfrom
anhkhoakz:fix/handle-missing-directory
Jun 27, 2026
Merged

fix(manager): remove stale plugins with missing directories#481
gschier merged 3 commits into
mountain-loop:mainfrom
anhkhoakz:fix/handle-missing-directory

Conversation

@anhkhoakz

Copy link
Copy Markdown
Contributor

Summary

Even the plugin directory missing, Yaak plugin manager still count it and try to exec it. Causing this error Failed to load plugin "yaak-plugin": IO error: No such file or directory (os error 2)

Submission

  • This PR is a bug fix or small-scope improvement.
  • If this PR is not a bug fix or small-scope improvement, I linked an approved feedback item below.
  • I have read and followed CONTRIBUTING.md.
  • I tested this change locally.
  • I added or updated tests when reasonable.

Approved feedback item (required if not a bug fix or small-scope improvement):

Related

@gschier gschier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here!

I changed the shape a bit because I didn't want Yaak to automatically uninstall plugins when their directory is missing (path could be temporarily unavailable, such as from an unmounted disk).

Instead, I updated the plugin listing flow so missing plugins still appear in the Installed Plugins tab, where the user can uninstall them manually if they want.

@gschier gschier merged commit 1de0a59 into mountain-loop:main Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants