UI: search button#1531
Draft
mority wants to merge 5 commits into
Draft
Conversation
Member
|
Maybe it could have its own row? Not sure how that would look like. |
Contributor
Author
I tried that at first, but then we would have to choose between a huge 'Options' button or some empty space in the row above. Or make it more responsive and move some options out of the dialog directly into the search mask for large viewports. My solution was to replace 'Options' with the settings wheel to make it fit into one row. |
Contributor
Author
Contributor
|
Frankly I'm still in favor of just not having a search button. The time picker is not really causing that many search triggers usually and that would IMO be the only reason why one would want a search button now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



played some tetris with the search mask, button does not do anything yet
looks huge on desktop

but this way it fits into one row on mobile
