Skip to content

nearest endpoint#1438

Open
DIDONAX wants to merge 11 commits into
motis-project:masterfrom
DIDONAX:nearest-endpoint
Open

nearest endpoint#1438
DIDONAX wants to merge 11 commits into
motis-project:masterfrom
DIDONAX:nearest-endpoint

Conversation

@DIDONAX

@DIDONAX DIDONAX commented May 23, 2026

Copy link
Copy Markdown
Contributor

@DIDONAX
DIDONAX marked this pull request as draft May 24, 2026 02:47
@DIDONAX
DIDONAX force-pushed the nearest-endpoint branch from 9630cc6 to 94e7dda Compare May 24, 2026 19:35
@DIDONAX
DIDONAX requested a review from felixguendling May 25, 2026 01:12
@DIDONAX
DIDONAX marked this pull request as ready for review May 25, 2026 01:12
Comment thread src/endpoints/nearest.cc
"invalid number");

std::swap(coord->pos_.lat_, coord->pos_.lng_);
api::NearestResponse res;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAA style

return d.l_->match<P>(
std::get<typename P::parameters>(osr::get_parameters(profile)), loc,
false, osr::direction::kForward, radius, nullptr);
});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't run the same code 2x
expect concrete results, no computation

Comment thread openapi.yaml
type: integer
default: 1

- name: radiuses

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name implies array?

@traines-source

Copy link
Copy Markdown
Contributor

Is /nearest/v1/{profile}/{coordinates} the path required by the "standard"? I think if possible we should then put it to a subpath (/api/v6/osrm/nearest/v1/{profile}/{coordinates} or sth), because it doesn't fit our path structure at all. If it's more flexible we should just make it fit our scheme IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants