Repository navigation
Stop automatic channel restoration when the connection closes - #717
Merged
Merged
Conversation
|
coverage: 92.723% (+0.06%) from 92.667% — fix/stop-restore-on-close into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a robust connection could trigger channel restoration after its transport had already been removed, logging
ChannelInvalidStateError: No active transport in channelduring shutdown.Skip automatic restoration when the connection is closing or closed, including after waiting for the restoration lock. If shutdown starts while restoration is already in progress, let the close callback finish without reporting the recovery failure. Restoration errors still propagate while the connection remains active, and cancellation is preserved.
Fixes #668.