Remove NODE_VERSION and ZIP_DIR from oidc-ui build job - #2552
Remove NODE_VERSION and ZIP_DIR from oidc-ui build job#2552SwapnilWorks-Devops wants to merge 1 commit into
Conversation
Both inputs were dropped from mosip/kattu npm-build.yml, so push-trigger.yml no longer validates and every push to release-2.0.x fails at startup. Backport of mosip#2526. Fixes mosip#2551 Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe push workflow removes ChangesWorkflow input cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This restores the OIDC UI workflow invocation by removing arguments no longer accepted by the reusable build workflow. No current merge-blocking risk is identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This is not required, as NODE_VERSION and ZIP_DIR are added in the rpm-build.yaml in kattu repo. Hence closing the PR. |
Backport of #2526 to
release-2.0.x.mosip/kattucommit b9db8b19 ("Refactor npm-build.yml for input simplification", 21 Aug 2026) removed theNODE_VERSIONandZIP_DIRinputs fromnpm-build.yml. We call that workflow at@develop, sopush-trigger.ymlstopped validating and every push torelease-2.0.xhas ended instartup_failuresince 28 Aug — no build, no Sonar, no docker images.This drops the two lines, identical to the fix already on
develop-go. No other changes.Fixes #2551
Signed-off-by: Swapnil swapnil.mohanty@technoforte.co.in
Summary by CodeRabbit