Skip to content

Remove NODE_VERSION and ZIP_DIR from oidc-ui build job - #2552

Closed
SwapnilWorks-Devops wants to merge 1 commit into
mosip:release-2.0.xfrom
SwapnilWorks-Devops:issues/2551
Closed

Remove NODE_VERSION and ZIP_DIR from oidc-ui build job#2552
SwapnilWorks-Devops wants to merge 1 commit into
mosip:release-2.0.xfrom
SwapnilWorks-Devops:issues/2551

Conversation

@SwapnilWorks-Devops

@SwapnilWorks-Devops SwapnilWorks-Devops commented Sep 7, 2026

Copy link
Copy Markdown

Backport of #2526 to release-2.0.x.

mosip/kattu commit b9db8b19 ("Refactor npm-build.yml for input simplification", 21 Aug 2026) removed the NODE_VERSION and ZIP_DIR inputs from npm-build.yml. We call that workflow at @develop, so push-trigger.yml stopped validating and every push to release-2.0.x has ended in startup_failure since 28 Aug — no build, no Sonar, no docker images.

.github/workflows/push-trigger.yml (Line: 88, Col: 21): Invalid input, NODE_VERSION is not defined in the referenced workflow.
.github/workflows/push-trigger.yml (Line: 89, Col: 16): Invalid input, ZIP_DIR is not defined in the referenced workflow.

This drops the two lines, identical to the fix already on develop-go. No other changes.

Fixes #2551

Signed-off-by: Swapnil swapnil.mohanty@technoforte.co.in

Summary by CodeRabbit

  • Chores
    • Updated the automated build workflow configuration.

Both inputs were dropped from mosip/kattu npm-build.yml, so push-trigger.yml
no longer validates and every push to release-2.0.x fails at startup.
Backport of mosip#2526.

Fixes mosip#2551

Signed-off-by: Swapnil <swapnil.mohanty@technoforte.co.in>
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Team

Run ID: c3e185c0-7b5b-4e46-9e5e-0fc2d84bf7ab

📥 Commits

Reviewing files that changed from the base of the PR and between 9999542 and f2842c3.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/push-trigger.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The push workflow removes NODE_VERSION and ZIP_DIR from the OIDC UI reusable workflow invocation. These inputs are no longer declared by the referenced npm build workflow.

Changes

Workflow input cleanup

Layer / File(s) Summary
Remove obsolete build inputs
.github/workflows/push-trigger.yml
The build-oidc-ui workflow call no longer passes NODE_VERSION or ZIP_DIR.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f2842

This restores the OIDC UI workflow invocation by removing arguments no longer accepted by the reusable build workflow. No current merge-blocking risk is identified.

Poem

Two inputs leave the flow
The build call now aligns
Undefined keys are gone
YAML starts clean
The pipeline moves on

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the removal of the obsolete NODE_VERSION and ZIP_DIR inputs from the OIDC UI build job.
Linked Issues check ✅ Passed The pull request removes both invalid inputs from build-oidc-ui, which addresses the primary failure described in issue #2551. The issue's workflow pinning and Sonar input concerns are explicitly outs…
Out of Scope Changes check ✅ Passed The pull request changes only the two obsolete inputs in .github/workflows/push-trigger.yml. The changes are directly related to issue #2551 and contain no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@anushasunkada

Copy link
Copy Markdown
Contributor

This is not required, as NODE_VERSION and ZIP_DIR are added in the rpm-build.yaml in kattu repo. Hence closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants