Confirm OTLP observability config for load runs - #2514
Conversation
Signed-off-by: mdhumair.kankudti <mdhumair.kankudti@infosys.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change adds observability configuration, preserves YAML values unless a valid environment override exists, adds tests for resolution behavior, and documents the current tracing implementation status. ChangesObservability configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change preserves configured observability settings while allowing explicit environment overrides, without activating telemetry or changing externally reachable behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop-go #2514 +/- ##
=============================================
Coverage ? 70.40%
=============================================
Files ? 129
Lines ? 8909
Branches ? 111
=============================================
Hits ? 6272
Misses ? 2176
Partials ? 461
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
MOSIP_ESIGNET_OBSERVABILITY_ENABLEDenvironment variable.Documentation