#55: Add GPG_PRIVATE_KEY secret pass-through and remove committed GPG keys - #328
#55: Add GPG_PRIVATE_KEY secret pass-through and remove committed GPG keys#328chetankh239 wants to merge 3 commits into
Conversation
Adds GPG_PRIVATE_KEY to the maven-build and maven-publish-to-nexus1 job secrets, and removes the leaked .github/keys/mosipgpgkey_*.gpg files from tracking. Adds a .gitignore excluding .github/keys/. Ref: mosip/mosip-labs#55 Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
|
Warning Review limit reached
Next review available in: 90 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chetankh239
changed the title
…from publish job maven-build.yml on gpgupdate-masterj21 supports GPG_PRIVATE_KEY, so the build job's ref is repointed there. However maven-publish-to-nexus1.yml (used by this repo's publish job, not the standard maven-publish-to-nexus.yml) has not been updated on any mosip/kattu branch to accept GPG_PRIVATE_KEY yet, so passing it there is invalid per CodeRabbit review on mosip/commons#1845. Dropping it here until kattu fixes maven-publish-to-nexus1.yml; that job still relies on GPG_SECRET only. Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
Reference PR mosip/imagedecoder#55 only removes the leaked key files from tracking; it does not add a .gitignore entry. Dropping the .github/keys/ ignore rule here to match that pattern. Note per CodeRabbit: this alone does not remediate the exposure - the key must still be treated as compromised, rotated, and purged from history at the org level. Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
1 participant
Summary
GPG_PRIVATE_KEYsecret pass-through to maven-build/maven-publish-to-nexus jobs in.github/workflows/push-trigger.yml, alongside the existingGPG_SECRET..github/keys/mosipgpgkey_pub.gpgand.github/keys/mosipgpgkey_sec.gpgfrom tracking and ignores.github/keys/going forward.Test plan
GPG_PRIVATE_KEYsecret is configured at the org/repo levelRef: mosip/mosip-labs#55