Wrap box with molbox's API#565
Open
umesh-timalsina wants to merge 14 commits into
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| lengths = _validate_lengths(lengths) | ||
| angles = _validate_angles(angles) | ||
| print(lengths, angles) | ||
| precision = int(precision or 6) |
Collaborator
There was a problem hiding this comment.
Does this set precision to 6 if you cant typecast precision to an int?
Member
Author
There was a problem hiding this comment.
I think it does because you have handled that in Molbox.
Collaborator
There was a problem hiding this comment.
Ah true, that makes sense.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 92.44% 90.53% -1.91%
==========================================
Files 66 56 -10
Lines 7024 4439 -2585
==========================================
- Hits 6493 4019 -2474
+ Misses 531 420 -111 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #563.