Skip to content

fix(artifacts): reject stopped Mach-O slice traversals - #9952

Open
morluto wants to merge 1 commit into
mainfrom
codex/macho-paused-enumeration
Open

morluto wants to merge 1 commit into
mainfrom
codex/macho-paused-enumeration

Conversation

@morluto

@morluto morluto commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Summary

A caller could cancel a Mach-O slice traversal after receiving a slice and still receive another slice or a successful completion. Closing a paused traversal could also report completion instead of a closed-reader failure.

Validate admission, resumed slice delivery, and final completion at the reader's existing active-state boundary. The shared assertion replaces repeated enumeration closed-state checks and preserves the exact opaque cancellation reason.

Validation

  • Against base 847d59c947, all three new paused-traversal regressions failed: cancellation between slices, cancellation after the final slice, and close after the final slice.
  • Four reader source suites: 80 passed; one installed-lipo case intentionally skipped. Controls cover active capture/read joining, stream cleanup retry, architecture binding, short reads, and the working FIT traversal sibling.
  • Standalone node scripts/run-typescript.mjs --noEmit passed.
  • Narrow oxlint exited 0 with four size/complexity warnings; formatting and diff checks passed.

Exactly the Mach-O reader and its test changed. Tests use authored files and controlled command results; no lipo or target executed. No runtime build or publication performed. This ordinary lifecycle correction adds no target authority.

Author readiness

Human owner:

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

@morluto
morluto marked this pull request as ready for review November 11, 2026 03:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T03:54:16.736230Z 10bd61f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant