Repository navigation
Conversation
Part of #9881. Add effect immediate or next_process and keep rea_restart_required, restart_required, and restartRequired as compatibility aliases.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4f927c94e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Callers read update_mode to see whether update_analysis_settings can change a limit, and pending_restart only when a configured value is not active in this process.
cursor
Bot
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2b7c3bb92
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Invalid ChangeTime settings now carry update_mode and pending_restart through the configuration error and its projection, including startup parsing. Runtime recoveries name update_analysis_settings instead of telling the caller to restart REA.
Depends on morluto#9885. That branch replaces rea_restart_required with update_mode and pending_restart and forbids the legacy fields.
Depends on morluto#9885. The $MFT limit uses update_mode and pending_restart, and the setting declares updateMode so the numeric-limit check accepts it.
Depends on morluto#9885. That branch replaces rea_restart_required with update_mode and pending_restart and forbids the legacy fields.
Depends on morluto#9885. The hive limit uses update_mode and pending_restart, and the setting declares updateMode so the numeric-limit check accepts it.
Depends on morluto#9885. That branch replaces rea_restart_required with update_mode and pending_restart and forbids the legacy fields.
Omit a path or URL literal when its serialized record, including provenance, does not fit the remaining worker result budget. When the count ceiling is already the setting maximum, report that ceiling as maximal. Depends on morluto#9885: the limit uses update_mode and pending_restart.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58b4b17fd3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
artifact_limits and web-network budgets report update_mode parameter because update_analysis_settings cannot change them. The legacy-name scan no longer reads docs, and the 2026-11-09 Ghidra receipts are restored to the fields they recorded.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb598a23cf
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
analysis_timeout_ms, max_heap_mb, and command_timeout_ms keep the source chosen by the caller, the runtime override, or the built-in default. A request value reports update_mode parameter because update_analysis_settings cannot change that call.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70f91ac602
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| The next release changes analysis-setting output (#9885). `update_analysis_settings`, `inspect_analysis_settings`, and limit errors no longer include `rea_restart_required`, `restart_required`, `restartRequired`, or `effect`. Read `update_mode` (`runtime` or `restart`) and `pending_restart`. There is no compatibility alias. Release Please should copy this migration into that release's breaking-changes section. | |||
There was a problem hiding this comment.
parameter in the documented update modes
The breaking-change migration says update_mode is only runtime or restart, but limit failures for artifact/web budgets and explicit JavaScript or WASM arguments now emit parameter (for example, ArtifactReaderLimits.ts and analysisSettingLimit). Clients implementing the changelog's stated enum can therefore reject valid error payloads or recommend the wrong recovery; document all three values in the release migration.
AGENTS.md reference: AGENTS.md:L99-L103
Useful? React with 👍 / 👎.
Breaking change
update_analysis_settings,inspect_analysis_settings, and limit errors no longer includeeffect,rea_restart_required,restart_required, orrestartRequired. There is no compatibility alias.Read
update_modeandpending_restart.runtimemeans the setter can change the active value.restartmeans this process keeps the value it started with.parametermeans this call supplied the value, soupdate_analysis_settingscannot change it. Artifact reader limits and web-network capture budgets useparameter, withpending_restart: false.javascript.analysis_timeout_ms,javascript.max_heap_mb, andwasm.command_timeout_mskeep the selection source. A caller argument issource: "request"andupdate_mode: "parameter". A runtime override issource: "runtime"andupdate_mode: "runtime". The built-in default issource: "default"andupdate_mode: "runtime".The 2026-11-09 Ghidra verification receipts keep the fields they recorded. The legacy-name scan does not read
docs.Summary
Part of #9881. This branch merges #9884. Numeric-limit discovery uses the TypeScript syntax tree: comments and array literals are not producers, and a later helper argument is.
Validation performed
npm run check:fast— passed.npm run test:local --analysis error projection, WABT failures, and the WASM service — passed (161 tests).npm run test:local -- src/wasm/WabtArtifactProvider.test.ts— passed (53 tests), including a request-selected command deadline withupdate_mode: "parameter".npm run test:focused -- tests/boundary/mcp/javascriptAnalysisResources.test.ts— passed (3 tests). A calleranalysis_timeout_msreportssource: "request"andupdate_mode: "parameter".Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.