Repository navigation
fix(cli): reject NUL bytes in binary overview paths - #9751
ShuaixinHuang wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf075632ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const localPath = z | ||
| .string() | ||
| .min(1) | ||
| .regex(/^[^\x00]*$/u, "Local path cannot contain NUL"); |
There was a problem hiding this comment.
The shared boundary already exports localPathStringSchema from src/domain/localPath.ts with these exact nonempty/NUL-free constraints, and src/cli/firmwareCommands.ts already uses it directly with Incur. Introducing an independent copy here means changes to the shared path contract must also be maintained separately for analyze. AGENTS.md requires directly related cleanup of duplicated interpretations when fixing a boundary bug; import and use the existing schema instead of defining another owner for the same validation rule.
AGENTS.md reference: AGENTS.md:L25-L25
Useful? React with 👍 / 👎.
Addresses #9749.
Aligns the analyze CLI path schema with the shared local path boundary by rejecting empty and NUL-containing paths before execution.
Author readiness
Human owner: @ShuaixinHuang