Skip to content

fix(gpu): reject impossible offload bundle counts before capacity - #9621

Open
morluto wants to merge 1 commit into
mainfrom
audit/gpu-count
Open

morluto wants to merge 1 commit into
mainfrom
audit/gpu-count

Conversation

@morluto

@morluto morluto commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

A Clang offload bundle containing only its header could declare an impossible directory count and report a resource limit. Check the raw uint64 declaration against the available minimum row extent before numeric conversion and capacity admission. A malformed file now reports a format failure; framed oversized directories keep their existing capacity refusal.

Each entry needs three 64-bit fields before its ID, as defined by the LLVM offload bundler. No new cap is added.

Validation and scope

The public-provider regression failed before repair. Node24:117 focused GPU tests and check:fast passed, including count0, short count65537/uint64 maximum and a framed over-budget directory with ID bytes. That capacity fixture establishes framing, not runnable code or semantic uniqueness. No real GPU compiler/runtime qualification. Existing parser repair; no new target authority, dependency, schema, installation or generated metadata. Maintainer scope decision not applicable.

Author readiness

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T11:19:43.237885Z 8babb8e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant