Repository navigation
fix(javascript): preserve cleanup failures during preparation cancellation - #1654
Merged
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
N0zoM1z0
marked this pull request as draft
October 10, 2026 23:53
N0zoM1z0
added
area: domain
N0zoM1z0
marked this pull request as ready for review
October 11, 2026 00:04
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
5 of 16 tasks
This was referenced Oct 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed retained JavaScript analyzer cleanup can coincide with cancellation of the next caller during preparation. Preserve
ProviderCleanupErrorinstead of replacing it with a completedcancelledresult, so the owned resource and retry diagnostic remain visible. Builds on main's preparation-cancellation correction.Verify the failure through a real owned Node worker with an injected cleanup callback failure, then allow verified cleanup and prove subsequent analysis recovers. Move the filesystem/process cancellation suite into boundary tests and assert its retained partial observation. The injected callback establishes this failure projection; an actual OS cleanup denial was not observed.
Validation: 16 real process/cancellation boundary cases;
npm run check:ci;npm run verify:test-discovery(794 files). Packed final headba885214and independently installed production dependencies on native Windows in an isolated Windows verification directory, using existing Node 22.19.0. Actual CLI JSON and pinned-SDK MCP pass: 170 tools, startup cancellation with retained partial evidence, timeout/partial views, subsequent successful analysis, paging/item lookup, tracing, close and ping. Input digests are unchanged and no owned worker roots remain. All 19 final-head GitHub checks passed, including the full test/coverage gate, Windows capability/package lane and both native package baselines. Real Hopper/Ghidra verification was not performed for this Node lifecycle change.Fixes #1653. Refs #1563 and #1065.