Skip to content

fix: color picker not opening in ios devices (@d1rshan) #8049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d1rshan wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −8
Open

fix: color picker not opening in ios devices (@d1rshan) #8049

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c05a4c4
fix
d1rshan Jun 3, 2026
35c2080
ahhh
d1rshan Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions frontend/src/ts/components/pages/settings/custom-setting/Theme.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,8 +514,6 @@ function ThemeButton(props: { theme: ThemeWithName }): JSXElement {
}

function Picker(props: { color: ColorName }): JSXElement {
let colorInputRef: HTMLInputElement | undefined = undefined;

const text = () => {
if (props.color === "bg") return "background";
if (props.color === "main") return "main";
Expand Down Expand Up @@ -583,13 +581,12 @@ function Picker(props: { color: ColorName }): JSXElement {
updateThemeColor(props.color, value);
}}
/>
<div class="grid">
<div class="relative">
<input
ref={(el) => (colorInputRef = el)}
type="color"
value={getTheme()[props.color]}
onInput={debouncedInput}
class="pointer-events-none col-[1/1] row-[1/1] m-0 h-full w-0 p-0 opacity-0"
class="pointer-events-auto absolute inset-0 z-10 h-full w-full cursor-pointer opacity-0"
Comment thread
d1rshan marked this conversation as resolved.
Outdated
Comment thread
d1rshan marked this conversation as resolved.
Outdated
// onChange={(e) => {
// const current = [...getConfig.customThemeColors];
// current[colorIndex()] = e.currentTarget.value;
Expand All @@ -601,7 +598,6 @@ function Picker(props: { color: ColorName }): JSXElement {
/>
<Button
class={cn(
`col-[1/1] row-[1/1]`,
`bg-(--picker-${props.color}) text-(--picker-bg)`,
`hover:bg-(--picker-text)`,
props.color === "bg" && "bg-(--picker-subAlt) text-(--picker-text)",
Expand All @@ -611,7 +607,6 @@ function Picker(props: { color: ColorName }): JSXElement {
icon: "fa-palette",
fixedWidth: true,
}}
onClick={() => colorInputRef?.click()}
/>
</div>
</div>
Expand Down
Loading