Skip to content

Patch std::map iterator assertion in hideToast #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohabouje merged 1 commit into from
Apr 20, 2026
Merged

Patch std::map iterator assertion in hideToast #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/wintoastlib.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,15 +927,21 @@ bool WinToast::hideToast(_In_ INT64 id) {
return false;
}

auto& notifyData = iter->second;
auto result = notify->Hide(notifyData.notification());
ComPtr<IToastNotification> notificationObj = iter->second.notification();

auto result = notify->Hide(notificationObj.Get());
if (FAILED(result)) {
DEBUG_MSG("Error when hiding the toast. Error code: " << result);
return false;
}

notifyData.RemoveTokens();
_buffer.erase(iter);
iter = _buffer.find(id);
if (iter != _buffer.end()) {
iter->second.markAsReadyForDeletion();
iter->second.RemoveTokens();
_buffer.erase(iter);
}

return SUCCEEDED(result);
}

Expand All @@ -948,9 +954,12 @@ void WinToast::clear() {

auto safeCopy = _buffer;
for (auto& data : safeCopy) {
auto& notifyData = data.second;
notify->Hide(notifyData.notification());
notifyData.RemoveTokens();
notify->Hide(data.second.notification());
}

for (auto& data : _buffer) {
data.second.markAsReadyForDeletion();
data.second.RemoveTokens();
}
_buffer.clear();
}
Expand Down
Loading