Conversation
matdave
marked this pull request as ready for review
September 10, 2026 14:05
Collaborator
|
Tested with modx-pr-tester. Browser: Chrome browser / macOS (Docker PHP 8.2). Local Filesystem media source: create/list/rename/move/remove OK (19/19 smoke). Did not test live S3/FTP remotes. |
Ibochkarev
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Update Flysystem to version 3. Currently MODX Is on Flysystem 2.x which has many broken features that have been left unmaintained. A critical broken feature is the inability to rename, move or copy objects in S3.
How to test
Apply the new composer.json and test file operations
Compatibility notes
Flysystem 3.x is stated as being backwards compatible with 2.x, with the primary difference being it requires PHP 8, which MODX also now requires.
Breaking change assessment
This is likely not patch level safe, as it is a full library upgrade.
Related Issues
thephpleague/flysystem#1759