Skip to content

fix(cli): warn when auth validation falls back to API #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puneetdixit200 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): warn when auth validation falls back to API #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion codecarbon/cli/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"""

import json
import logging
import os
import webbrowser
from http.server import BaseHTTPRequestHandler, HTTPServer
Expand All @@ -31,6 +32,7 @@
_REDIRECT_PORT = 8090
_REDIRECT_URI = f"http://localhost:{_REDIRECT_PORT}/callback"
_CREDENTIALS_FILE = Path("./credentials.json")
logger = logging.getLogger(__name__)


# ── OAuth callback server ───────────────────────────────────────────
Expand Down Expand Up @@ -112,7 +114,12 @@ def _validate_access_token(access_token: str) -> bool:
claims = jose_jwt.decode(access_token, keyset)
claims.validate()
return True
except requests.RequestException:
except requests.RequestException as exc:
logger.warning(
"Skipping local access token validation because the auth server is "
"unreachable; the API will validate the token. Error: %s",
exc,
)
return True # Can't reach auth server — let the API handle it
except Exception:
return False
Expand Down
5 changes: 4 additions & 1 deletion tests/cli/test_cli_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@ def test_validate_access_token_valid(
def test_validate_access_token_network_error_returns_true(
self, mock_get, mock_discover
):
self.assertTrue(auth._validate_access_token("token"))
with self.assertLogs("codecarbon.cli.auth", level="WARNING") as logs:
self.assertTrue(auth._validate_access_token("token"))

self.assertIn("Skipping local access token validation", logs.output[0])

@patch("codecarbon.cli.auth._discover_endpoints", return_value={"jwks_uri": "jwks"})
@patch("codecarbon.cli.auth.requests.get")
Expand Down