chore(core): stop writing failure screenshots next to tests - #3068
Open
Lisa18289 wants to merge 1 commit into
Open
chore(core): stop writing failure screenshots next to tests#3068Lisa18289 wants to merge 1 commit into
Lisa18289 wants to merge 1 commit into
Conversation
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
Lisa18289
marked this pull request as ready for review
September 2, 2026 10:43
Lisa18289
force-pushed
the
chore/no-stray-failure-screenshots
branch
from
September 3, 2026 11:12
3d8c952 to
993b385
Compare
Lisa18289
enabled auto-merge (squash)
September 3, 2026 11:13
Vitest's `screenshotFailures` defaults to on, and no `__screenshots__` directory is gitignored — they hold the committed visual baselines — so a red browser test drops a PNG that `git add -A` sweeps into the commit. Two such strays are on main already, in List and MarkdownEditor, referenced by no test. Turning it off in the shared browser config covers every package that inherits it, including future browser projects; the local overrides in remote-react-components become redundant. A failing visual test still writes reference, actual and diff to the gitignored .vitest-attachments, and `--browser.screenshotFailures` brings a screenshot back on demand. PATTERNS.md listed screenshot baselines as a pattern of the components package — the two strays were its only evidence. It points at the visual suite now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Lisa18289
force-pushed
the
chore/no-stray-failure-screenshots
branch
from
September 3, 2026 11:15
993b385 to
9b74958
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vitest's
screenshotFailuresdefaults to on, and no__screenshots__directory is gitignored — they hold the committed visual baselines — so a red browser test drops a PNG thatgit add -Asweeps into the commit. Two such strays are on main already, inListandMarkdownEditor, referenced by no test.Turning it off in the shared browser config covers every package that inherits it, including future browser projects, so the local overrides in
remote-react-componentsbecome redundant. A failing visual test still writes reference, actual and diff to the gitignored.vitest-attachments, and--browser.screenshotFailuresbrings a screenshot back on demand.PATTERNS.mdlisted screenshot baselines as a pattern of the components package — the two strays were its only evidence. It points at the visual suite now.Verified in both directions with a deliberately failing browser test in
components: no screenshot and no__screenshots__directory by default, the PNG back with the flag.Alert.browser.test.tsx --project=visualstays green, sotoMatchScreenshotbaselines resolve unchanged.Test config, docs and deleted artifacts only — nothing to release.
🤖 Generated with Claude Code